nastra commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1420212153
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -142,15 +148,27 @@ private UpdateableReference loadReference(String
requestedRef, String hash) {
}
public List<TableIdentifier> listTables(Namespace namespace) {
+ return listContents(namespace, Content.Type.ICEBERG_TABLE);
+ }
+
+ public List<TableIdentifier> listViews(Namespace namespace) {
+ return listContents(namespace, Content.Type.ICEBERG_VIEW);
+ }
+
+ /** Lists Iceberg table or view from the given namespace */
+ protected List<TableIdentifier> listContents(Namespace namespace,
Content.Type type) {
Review Comment:
is there any value in keeping this (and others) protected? I would have
thought it should be ok to make this private, since all the other places would
then use the table/view-specific methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
