nastra commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419073781
##########
nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java:
##########
@@ -267,4 +305,23 @@ static DataFile makeDataFile(Table icebergTable, String
fileLocation) {
.withFileSizeInBytes(Files.localInput(fileLocation).getLength())
.build();
}
+
+ protected static List<String> metadataVersionFiles(String tablePath) {
+ return filterByExtension(tablePath,
getFileExtension(TableMetadataParser.Codec.NONE));
+ }
+
+ protected static List<String> filterByExtension(String tablePath, String
extension) {
+ return metadataFiles(tablePath).stream()
+ .filter(f -> f.endsWith(extension))
+ .collect(Collectors.toList());
+ }
+
+ @SuppressWarnings(
+ "RegexpSinglelineJava") // respecting this rule requires a lot more
lines of code
Review Comment:
nit: can this be moved to the line above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
