ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1419953116
########## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ########## @@ -141,16 +147,26 @@ private UpdateableReference loadReference(String requestedRef, String hash) { } } + /** @deprecated will be removed after 1.5.0; use listContents() instead */ + @Deprecated Review Comment: `commitTable()` / `commitView()` are different method as they work on different objects like (`TableMetadata`/`ViewMetadata`). Rest of the methods uses same object (or signature). So they are unified. Providing `listViews()` (other new methods for views) seems redundant and more confusing like why both `listViews()` and `listContents()` are public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org