pvary commented on PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#issuecomment-2059391305
Merged to main.
Thanks for the PR @rodmeneses and @nastra for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
pvary merged PR #10112:
URL: https://github.com/apache/iceberg/pull/10112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
pvary commented on PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#issuecomment-2059345426
> Why do we remove Flink 1.1.6 in this PR?
@manuzhang: This is how we usually do these changes. We support the 3 last
version of Flink, so when we add a new version, we remove the o
rodmeneses commented on PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#issuecomment-2059306340
> > @nastra: Any comments? I would like to merge this soon, as any merge to
Flink code path will make this PR stale, and @rodmeneses needs to recreate the
whole PR.
> > Thanks,
nastra commented on PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#issuecomment-2058425533
> @nastra: Any comments? I would like to merge this soon, as any merge to
Flink code path will make this PR stale, and @rodmeneses needs to recreate the
whole PR.
>
> Thanks,
nastra commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1566855387
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##
@@ -391,17 +391,16 @@ public void createTable(ObjectPath tablePath,
CatalogBaseTable
nastra commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1566852990
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##
@@ -391,17 +391,16 @@ public void createTable(ObjectPath tablePath,
CatalogBaseTable
nastra commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1566850598
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##
@@ -391,17 +391,16 @@ public void createTable(ObjectPath tablePath,
CatalogBaseTable
manuzhang commented on PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#issuecomment-2058257988
Why do we remove Flink 1.1.6 in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
nastra commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1565260333
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkSource.java:
##
@@ -60,7 +60,7 @@ protected List runWithFilter(Expression filter, String
s
rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1564892433
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestChangeLogTable.java:
##
@@ -98,7 +98,7 @@ public void before() {
@Override
public void clean(
rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1564937403
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestIcebergConnector.java:
##
@@ -257,20 +257,12 @@ public void testCreateTableUnderDefaultDatabase() {
rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1564895113
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java:
##
@@ -69,7 +69,9 @@ public class FlinkCatalogFactory implements CatalogFacto
rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1564892433
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestChangeLogTable.java:
##
@@ -98,7 +98,7 @@ public void before() {
@Override
public void clean(
rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1564895113
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java:
##
@@ -69,7 +69,9 @@ public class FlinkCatalogFactory implements CatalogFacto
rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1564895113
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java:
##
@@ -69,7 +69,9 @@ public class FlinkCatalogFactory implements CatalogFacto
rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1564892433
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestChangeLogTable.java:
##
@@ -98,7 +98,7 @@ public void before() {
@Override
public void clean(
rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1561382610
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestChangeLogTable.java:
##
@@ -98,7 +98,7 @@ public void before() {
@Override
public void clean(
rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1561381139
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamingMonitorFunction.java:
##
@@ -248,6 +248,7 @@ public void testInvalidMaxPlanningSnap
rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1561380930
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImpl.java:
##
@@ -443,9 +446,10 @@ public void
testIncreme
rodmeneses commented on PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#issuecomment-2050175110
> @rodmeneses: Just curious to know what command you have used for the step
"Flink: Recover flink/1.18 files from history" ? It is really nice.
>
> I thought the only way was t
ajantha-bhat commented on PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#issuecomment-2049367693
@rodmeneses: Just curious to know what command you have used for the step
"Flink: Recover flink/1.18 files from history" ?
It is really nice.
I thought the only way was
nastra commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1560519389
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java:
##
@@ -294,39 +308,284 @@ public void testAlterTable() throws
TableNotExistExc
nastra commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1560518381
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkInputFormatReaderDeletes.java:
##
@@ -35,6 +35,7 @@
import org.apache.iceberg.util.StructL
nastra commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1560516897
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamingMonitorFunction.java:
##
@@ -248,6 +248,7 @@ public void testInvalidMaxPlanningSnapshot
nastra commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1560516528
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImpl.java:
##
@@ -443,9 +446,10 @@ public void
testIncremental
pvary commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1560439436
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestChangeLogTable.java:
##
@@ -98,7 +98,7 @@ public void before() {
@Override
public void clean() {
pvary commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1560437038
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/FlinkTestBase.java:
##
@@ -126,4 +126,18 @@ protected void dropCatalog(String catalogName, boolean
ifExists
rodmeneses commented on PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#issuecomment-2048507129
cc: @pvary @stevenzwu @mas-chen please take a look at your earliest
convenience. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
29 matches
Mail list logo
