rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1561380930
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImpl.java:
##########
@@ -443,9 +446,10 @@ public void
testIncrementalFromSnapshotTimestampWithInvalidIds() throws Exceptio
ContinuousSplitPlannerImpl splitPlanner =
new ContinuousSplitPlannerImpl(
tableResource.tableLoader().clone(),
scanContextWithInvalidSnapshotId, null);
+
Review Comment:
HI @nastra and thanks a lot for your reviews.
Some comments:
1. The best way to review this PR is by looking at individual commits. The
most important one is the 4th commit called "Flink: Refactoring code and
properties to make Flink 1.19 to work". If you review that particular one, you
will notice that I'm not introducing the extra line changes.
2. The reason you're seeing those changes is because of the way Github is
presenting the differences, which is showing the complete set of differences in
the whole PR, and somehow, it's showing diff between the new 1.19 code and the
old 1.16 code
3. Now, we do we even have those changes? This is because of a previous back
port of changes between versions. There were some inconsistencies when the back
port was made and on those old commits the extra lines (or the use of
`Assertions.assertThatThrownBy` instead of statically imported) were introduced.
4. So, again, these changes you're referring to are not part of this PR.
5. I updated the PR description with the exact steps I take to create the PR
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
