rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1564937403
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestIcebergConnector.java:
##########
@@ -257,20 +257,12 @@ public void testCreateTableUnderDefaultDatabase() {
public void testCatalogDatabaseConflictWithFlinkDatabase() {
sql("CREATE DATABASE IF NOT EXISTS `%s`", databaseName());
sql("USE `%s`", databaseName());
-
- try {
- testCreateConnectorTable();
- // Ensure that the table was created under the specific database.
- Assertions.assertThatThrownBy(
- () -> sql("CREATE TABLE `default_catalog`.`%s`.`%s`",
databaseName(), TABLE_NAME))
- .isInstanceOf(org.apache.flink.table.api.TableException.class)
- .hasMessageStartingWith("Could not execute CreateTable in path");
- } finally {
- sql("DROP TABLE IF EXISTS `%s`.`%s`", databaseName(), TABLE_NAME);
- if (!isDefaultDatabaseName()) {
- sql("DROP DATABASE `%s`", databaseName());
- }
- }
+ testCreateConnectorTable();
Review Comment:
Up to this point in the unit test, there's only one catalog
`default_catalog` created and only one database `default_database` created so
far. So, trying to drop that database will fail, as we are currently using it,
and because if `FLINK-33226`, it will be impossible to drop the database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
