rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1564895113
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java:
##########
@@ -69,7 +69,9 @@ public class FlinkCatalogFactory implements CatalogFactory {
public static final String HIVE_CONF_DIR = "hive-conf-dir";
public static final String HADOOP_CONF_DIR = "hadoop-conf-dir";
public static final String DEFAULT_DATABASE = "default-database";
- public static final String DEFAULT_DATABASE_NAME = "default";
+ public static final String DEFAULT_DATABASE_NAME = "default_database";
Review Comment:
This is needed for
```
TestIcebergConnector.testCatalogDatabaseConflictWithFlinkDatabase
```
that unit test drops a database, under this condition:
```
if (!isDefaultDatabaseName()) {
sql("DROP DATABASE `%s`", databaseName());
}
```
Now, in this unit test context, there only exists one catalog
(`default_catalog`) and one database (`default_database`). So, it is impossible
to drop that DB because of https://github.com/apache/flink/pull/23501
Also, I noticed that when you switch to `default_catalog` and you try to get
the list of databases, the database returned has name `default_database` and
not `default`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
