nastra commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1566855387
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -391,17 +391,16 @@ public void createTable(ObjectPath tablePath,
CatalogBaseTable table, boolean ig
+ "an iceberg catalog, Please create table with
'connector'='iceberg' property in a non-iceberg catalog or "
+ "create table without 'connector'='iceberg' related properties
in an iceberg table.");
}
-
- createIcebergTable(tablePath, table, ignoreIfExists);
+ Preconditions.checkArgument(table instanceof ResolvedCatalogTable, "table
should be resolved");
Review Comment:
I think the problem is that the diff is still from a previous attempt where
changes were done based on Flink 1.16. What about removing Flink 1.16 building
from the gradle files but doing the actual remove of Flink 1.16 folders in a
separate PR? I think that would avoid these diffs here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
