nastra commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1565260333
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkSource.java:
##########
@@ -60,7 +60,7 @@ protected List<Row> runWithFilter(Expression filter, String
sqlFilter, boolean c
protected List<Row> runWithOptions(Map<String, String> options) throws
Exception {
FlinkSource.Builder builder = FlinkSource.forRowData();
Optional.ofNullable(options.get("case-sensitive"))
- .ifPresent(value ->
builder.caseSensitive(Boolean.parseBoolean(value)));
+ .ifPresent(value -> builder.caseSensitive(Boolean.getBoolean(value)));
Review Comment:
parseBoolean is correct here (this has just been recently changed on main)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
