rodmeneses commented on code in PR #10112:
URL: https://github.com/apache/iceberg/pull/10112#discussion_r1564892433


##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestChangeLogTable.java:
##########
@@ -98,7 +98,7 @@ public void before() {
   @Override
   public void clean() {
     sql("DROP TABLE IF EXISTS %s", TABLE_NAME);
-    sql("DROP DATABASE IF EXISTS %s", DATABASE_NAME);
+    dropDatabase(DATABASE_NAME, true);

Review Comment:
   I ended up changing this implementation of `dropDatabase` to:
   ```
     protected void dropDatabase(String database, boolean ifExists) {
       sql("USE CATALOG %s", DEFAULT_CATALOG_NAME);
       sql("USE %s", DEFAULT_DATABASE_NAME);
       sql("DROP DATABASE %s %s", ifExists ? "IF EXISTS" : "", database);
     }
   ```
   which is similar to our current `dropCatalog` implementation. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to