Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-12-05 Thread via GitHub
rdblue commented on PR #7913: URL: https://github.com/apache/iceberg/pull/7913#issuecomment-1841096970 Thanks @nastra! Great to have this in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-12-05 Thread via GitHub
rdblue merged PR #7913: URL: https://github.com/apache/iceberg/pull/7913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-12-05 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1415576999 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -247,8 +247,9 @@ public void createViewErrorCases() { .withQuery(trino.di

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-12-05 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1415636902 ## core/src/main/java/org/apache/iceberg/view/ViewMetadata.java: ## @@ -283,20 +292,25 @@ private int addVersionInternal(ViewVersion version) { } } -

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-12-05 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1415623593 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1534,4 +1535,90 @@ public void updateViewLocationConflict() { .isInstanceOf(NoSuchVi

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-12-05 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1415582206 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1534,4 +1535,90 @@ public void updateViewLocationConflict() { .isInstanceOf(NoSuchVi

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-12-05 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1415576999 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -247,8 +247,9 @@ public void createViewErrorCases() { .withQuery(trino.di

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-12-04 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1414697348 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1534,4 +1535,90 @@ public void updateViewLocationConflict() { .isInstanceOf(NoSuchVi

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-12-04 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1414688045 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1534,4 +1535,90 @@ public void updateViewLocationConflict() { .isInstanceOf(NoSuchVi

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-12-04 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1414687369 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1534,4 +1535,90 @@ public void updateViewLocationConflict() { .isInstanceOf(NoSuchVi

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-12-04 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1414686074 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -247,8 +247,9 @@ public void createViewErrorCases() { .withQuery(trino.di

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-12-04 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1414683541 ## core/src/main/java/org/apache/iceberg/view/ViewMetadata.java: ## @@ -283,20 +292,25 @@ private int addVersionInternal(ViewVersion version) { } } -

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-11-08 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1386806741 ## core/src/main/java/org/apache/iceberg/view/ViewMetadata.java: ## @@ -257,8 +258,8 @@ public Builder addVersion(ViewVersion version) { return this; } -

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-11-08 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1386793375 ## open-api/rest-catalog-open-api.yaml: ## @@ -1630,6 +1990,102 @@ components: metadata-log: $ref: '#/components/schemas/MetadataLog' +SQLViewR

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-11-02 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1379704585 ## core/src/main/java/org/apache/iceberg/UpdateRequirement.java: ## @@ -20,11 +20,17 @@ import org.apache.iceberg.exceptions.CommitFailedException; import org.apache

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-11-01 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1379226089 ## core/src/main/java/org/apache/iceberg/UpdateRequirement.java: ## @@ -20,11 +20,17 @@ import org.apache.iceberg.exceptions.CommitFailedException; import org.apache

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-30 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1375964778 ## core/src/main/java/org/apache/iceberg/UpdateRequirement.java: ## @@ -20,11 +20,17 @@ import org.apache.iceberg.exceptions.CommitFailedException; import org.apache

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-30 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1375930609 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +386,128 @@ static TableMetadata commit(TableOperations ops, UpdateTableRequest request

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-28 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1375318196 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +386,128 @@ static TableMetadata commit(TableOperations ops, UpdateTableRequest request

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-28 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1375318035 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +386,128 @@ static TableMetadata commit(TableOperations ops, UpdateTableRequest request

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-28 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1375317766 ## core/src/main/java/org/apache/iceberg/UpdateRequirement.java: ## @@ -20,11 +20,17 @@ import org.apache.iceberg.exceptions.CommitFailedException; import org.apache

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-28 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1375317766 ## core/src/main/java/org/apache/iceberg/UpdateRequirement.java: ## @@ -20,11 +20,17 @@ import org.apache.iceberg.exceptions.CommitFailedException; import org.apache

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-23 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1368378892 ## core/src/main/java/org/apache/iceberg/rest/RESTViewOperations.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-23 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1368356669 ## open-api/rest-catalog-open-api.yaml: ## @@ -2033,6 +2537,68 @@ components: metadata-location: type: string +CreateViewRequest: + type:

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-23 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1368352618 ## open-api/rest-catalog-open-api.yaml: ## @@ -1860,6 +2320,26 @@ components: items: type: string +AddViewVersionUpdate: + all

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-23 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1368347557 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -971,4 +996,261 @@ public void commitTransaction(SessionContext context, List commits)

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-23 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1368337508 ## open-api/rest-catalog-open-api.yaml: ## @@ -1056,6 +1056,357 @@ paths: } } + /v1/{prefix}/namespaces/{namespace}/views: +parame

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-23 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1368330924 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -943,11 +968,11 @@ private static Cache newSessionCache(Map pr .build(); } -

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-23 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1368329224 ## open-api/rest-catalog-open-api.yaml: ## @@ -2033,6 +2537,68 @@ components: metadata-location: type: string +CreateViewRequest: + type:

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-23 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1368326061 ## core/src/main/java/org/apache/iceberg/rest/RESTViewOperations.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-23 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1368323650 ## open-api/rest-catalog-open-api.yaml: ## @@ -2033,6 +2537,68 @@ components: metadata-location: type: string +CreateViewRequest: + type:

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-23 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1368319133 ## open-api/rest-catalog-open-api.yaml: ## @@ -1056,6 +1056,357 @@ paths: } } + /v1/{prefix}/namespaces/{namespace}/views: +parame

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-21 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367684201 ## core/src/main/java/org/apache/iceberg/rest/RESTViewOperations.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-21 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367683519 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1444,9 +1522,14 @@ public void updateViewLocationConflict() { catalog().dropView(identif

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367567052 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +386,128 @@ static TableMetadata commit(TableOperations ops, UpdateTableRequest request

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r136759 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +385,107 @@ static TableMetadata commit(TableOperations ops, UpdateTableRequest request

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367565894 ## core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java: ## @@ -35,17 +35,22 @@ import org.apache.iceberg.catalog.SupportsNamespaces; import org.apache.iceberg.

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367565571 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -943,11 +968,11 @@ private static Cache newSessionCache(Map pr .build(); } -

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367565262 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -971,4 +996,261 @@ public void commitTransaction(SessionContext context, List commits)

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367564841 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -971,4 +996,261 @@ public void commitTransaction(SessionContext context, List commits)

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367563075 ## core/src/main/java/org/apache/iceberg/rest/RESTViewOperations.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367562363 ## core/src/main/java/org/apache/iceberg/rest/RESTViewOperations.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367562181 ## core/src/main/java/org/apache/iceberg/rest/RESTViewOperations.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367560695 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -89,11 +94,13 @@ public class RESTCatalogAdapter implements RESTClient { private final

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367558698 ## open-api/rest-catalog-open-api.yaml: ## @@ -2033,6 +2537,68 @@ components: metadata-location: type: string +CreateViewRequest: + type:

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367558132 ## open-api/rest-catalog-open-api.yaml: ## @@ -2033,6 +2537,68 @@ components: metadata-location: type: string +CreateViewRequest: + type:

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367558418 ## open-api/rest-catalog-open-api.yaml: ## @@ -2033,6 +2537,68 @@ components: metadata-location: type: string +CreateViewRequest: + type:

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367558272 ## open-api/rest-catalog-open-api.yaml: ## @@ -2033,6 +2537,68 @@ components: metadata-location: type: string +CreateViewRequest: + type:

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367557579 ## open-api/rest-catalog-open-api.yaml: ## @@ -1860,6 +2320,26 @@ components: items: type: string +AddViewVersionUpdate: + all

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367556869 ## open-api/rest-catalog-open-api.yaml: ## @@ -1630,6 +1990,102 @@ components: metadata-log: $ref: '#/components/schemas/MetadataLog' +SQLViewR

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367556869 ## open-api/rest-catalog-open-api.yaml: ## @@ -1630,6 +1990,102 @@ components: metadata-log: $ref: '#/components/schemas/MetadataLog' +SQLViewR

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367555467 ## open-api/rest-catalog-open-api.yaml: ## @@ -1056,6 +1056,357 @@ paths: } } + /v1/{prefix}/namespaces/{namespace}/views: +parame

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367555195 ## open-api/rest-catalog-open-api.yaml: ## @@ -1056,6 +1056,357 @@ paths: } } + /v1/{prefix}/namespaces/{namespace}/views: +parame

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367554935 ## open-api/rest-catalog-open-api.yaml: ## @@ -1056,6 +1056,357 @@ paths: } } + /v1/{prefix}/namespaces/{namespace}/views: +parame

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367546614 ## core/src/main/java/org/apache/iceberg/catalog/BaseSessionCatalog.java: ## @@ -30,8 +30,10 @@ import org.apache.iceberg.exceptions.NamespaceNotEmptyException; import

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-18 Thread via GitHub
ajantha-bhat commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1363486980 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1444,9 +1522,14 @@ public void updateViewLocationConflict() { catalog().dropView(i

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-16 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1360265755 ## open-api/rest-catalog-open-api.yaml: ## @@ -1630,6 +1990,102 @@ components: metadata-log: $ref: '#/components/schemas/MetadataLog' +SQLViewR

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-13 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1358620356 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +385,107 @@ static TableMetadata commit(TableOperations ops, UpdateTableRequest request

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-13 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1358250961 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +385,107 @@ static TableMetadata commit(TableOperations ops, UpdateTableRequest request

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-09 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1351025602 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +385,107 @@ static TableMetadata commit(TableOperations ops, UpdateTableRequest request

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-09 Thread via GitHub
rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1351018901 ## core/src/main/java/org/apache/iceberg/catalog/BaseSessionCatalog.java: ## @@ -30,8 +30,10 @@ import org.apache.iceberg.exceptions.NamespaceNotEmptyException; import

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1347539389 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +385,107 @@ static TableMetadata commit(TableOperations ops, UpdateTableReque

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-04 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1346082143 ## open-api/rest-catalog-open-api.yaml: ## @@ -1014,6 +1014,357 @@ paths: } } + /v1/{prefix}/namespaces/{namespace}/views: +parame

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-04 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1346067694 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -568,4 +649,9 @@ private static TableIdentifier identFromPathVars(Map pathVars) { retu

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-04 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1345527136 ## core/src/main/java/org/apache/iceberg/catalog/BaseSessionCatalog.java: ## @@ -30,8 +30,10 @@ import org.apache.iceberg.exceptions.NamespaceNotEmptyException; import

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-02 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1342796092 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +385,107 @@ static TableMetadata commit(TableOperations ops, UpdateTableRequest request

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-02 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1342796092 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +385,107 @@ static TableMetadata commit(TableOperations ops, UpdateTableRequest request

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-02 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1342408996 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +385,107 @@ static TableMetadata commit(TableOperations ops, UpdateTableRequest request

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-02 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1342576396 ## open-api/rest-catalog-open-api.yaml: ## @@ -1630,6 +1990,102 @@ components: metadata-log: $ref: '#/components/schemas/MetadataLog' +SQLViewR

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-02 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1342409802 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -971,4 +996,250 @@ public void commitTransaction(SessionContext context, List commits)

Re: [PR] Core: Add View support for REST catalog [iceberg]

2023-10-02 Thread via GitHub
nastra commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1342408996 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,4 +385,107 @@ static TableMetadata commit(TableOperations ops, UpdateTableRequest request