rdblue commented on code in PR #7913:
URL: https://github.com/apache/iceberg/pull/7913#discussion_r1367567052
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -374,4 +386,128 @@ static TableMetadata commit(TableOperations ops,
UpdateTableRequest request) {
return ops.current();
}
+
+ private static BaseView baseView(View view) {
+ Preconditions.checkArgument(view instanceof BaseView, "View must be a
BaseView");
+ return (BaseView) view;
+ }
+
+ public static ListTablesResponse listViews(ViewCatalog catalog, Namespace
namespace) {
+ return
ListTablesResponse.builder().addAll(catalog.listViews(namespace)).build();
+ }
+
+ public static LoadViewResponse createView(
+ ViewCatalog catalog, Namespace namespace, CreateViewRequest request) {
+ request.validate();
+
+ ViewBuilder viewBuilder =
+ catalog
+ .buildView(TableIdentifier.of(namespace, request.name()))
+ .withSchema(request.schema())
+ .withProperties(request.properties())
+ .withDefaultNamespace(request.viewVersion().defaultNamespace())
+ .withDefaultCatalog(request.viewVersion().defaultCatalog())
+ .withLocation(request.location());
+
+ Set<String> unsupportedRepresentations =
+ request.viewVersion().representations().stream()
+ .filter(r -> !(r instanceof SQLViewRepresentation))
+ .map(ViewRepresentation::type)
+ .collect(Collectors.toSet());
+
+ if (!unsupportedRepresentations.isEmpty()) {
+ throw new IllegalStateException(
+ String.format("Found unsupported view representations: %s",
unsupportedRepresentations));
+ }
+
+ request.viewVersion().representations().stream()
Review Comment:
Note that this ignores the schema ID of the view version. I'm okay with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
