rdblue commented on code in PR #7913:
URL: https://github.com/apache/iceberg/pull/7913#discussion_r1414683541
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -283,20 +292,25 @@ private int addVersionInternal(ViewVersion version) {
}
}
- ViewVersion newVersion;
if (newVersionId != version.versionId()) {
- newVersion =
ImmutableViewVersion.builder().from(version).versionId(newVersionId).build();
+ version =
ImmutableViewVersion.builder().from(version).versionId(newVersionId).build();
+ }
Review Comment:
Nit: Now that the version may be updated more than once, it probably makes
more sense to relocate this to just after the new version ID is assigned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
