nastra commented on code in PR #7913:
URL: https://github.com/apache/iceberg/pull/7913#discussion_r1386806741
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -257,8 +258,8 @@ public Builder addVersion(ViewVersion version) {
return this;
}
- private int addVersionInternal(ViewVersion version) {
- int newVersionId = reuseOrCreateNewViewVersionId(version);
+ private int addVersionInternal(ViewVersion newVersion) {
Review Comment:
I've renamed this parameter to make the code slightly easier to understand,
because we have a few cases in this method where we re-assign either the schema
id or the view version id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
