nastra commented on code in PR #7913:
URL: https://github.com/apache/iceberg/pull/7913#discussion_r1342409802
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -971,4 +996,250 @@ public void commitTransaction(SessionContext context,
List<TableCommit> commits)
headers(context),
ErrorHandlers.tableCommitHandler());
}
+
+ @Override
+ public List<TableIdentifier> listViews(SessionContext context, Namespace
namespace) {
+ checkNamespaceIsValid(namespace);
+
+ ListTablesResponse response =
+ client.get(
+ paths.views(namespace),
+ ListTablesResponse.class,
+ headers(context),
+ ErrorHandlers.namespaceErrorHandler());
+ return response.identifiers();
+ }
+
+ @Override
+ public View loadView(SessionContext context, TableIdentifier identifier) {
+ checkViewIdentifierIsValid(identifier);
+
+ LoadViewResponse response =
+ client.get(
+ paths.view(identifier),
+ LoadViewResponse.class,
+ headers(context),
+ ErrorHandlers.viewErrorHandler());
+
+ AuthSession session = tableSession(response.config(), session(context));
+ ViewMetadata metadata = response.metadata();
+
+ RESTViewOperations ops =
+ new RESTViewOperations(
+ client,
+ paths.view(identifier),
+ session::headers,
+ tableFileIO(context, response.config()),
+ metadata);
+
+ trackFileIO(ops);
+
+ return new BaseView(ops, ViewUtil.fullViewName(name(), identifier));
+ }
+
+ @Override
+ public RESTViewBuilder buildView(SessionContext context, TableIdentifier
identifier) {
+ return new RESTViewBuilder(context, identifier);
+ }
+
+ @Override
+ public boolean dropView(SessionContext context, TableIdentifier identifier) {
+ checkViewIdentifierIsValid(identifier);
+
+ try {
+ client.delete(
+ paths.view(identifier), null, headers(context),
ErrorHandlers.viewErrorHandler());
+ return true;
+ } catch (NoSuchViewException e) {
+ return false;
+ }
+ }
+
+ @Override
+ public void renameView(SessionContext context, TableIdentifier from,
TableIdentifier to) {
+ checkViewIdentifierIsValid(from);
+ checkViewIdentifierIsValid(to);
+
+ RenameTableRequest request =
+
RenameTableRequest.builder().withSource(from).withDestination(to).build();
+
+ client.post(
+ paths.renameView(), request, null, headers(context),
ErrorHandlers.viewErrorHandler());
+ }
+
+ private class RESTViewBuilder implements ViewBuilder {
+ private final SessionContext context;
+ private final TableIdentifier identifier;
+ private final ImmutableViewVersion.Builder viewVersionBuilder =
ImmutableViewVersion.builder();
Review Comment:
yes, this PR hasn't been updated yet to reflect the new changes we did for
#7880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
