ajantha-bhat commented on code in PR #7913:
URL: https://github.com/apache/iceberg/pull/7913#discussion_r1363486980
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -1444,9 +1522,14 @@ public void updateViewLocationConflict() {
catalog().dropView(identifier);
assertThat(catalog().viewExists(identifier)).as("View should not
exist").isFalse();
+ String expectedMessage =
+ catalog() instanceof RESTCatalog ? "View does not exist: ns.view" :
"Cannot commit";
+ Class<?> expectedException =
+ catalog() instanceof RESTCatalog ? NoSuchViewException.class :
CommitFailedException.class;
Review Comment:
can you please move the changes in viewCatalogTests to the separate PR and
merge it first?
I am working on View support for Nessie catalog and these tests are failing
for me too.
Also I think we cannot have a catalog specific check in this class. It will
become too clumsy once we extend this test for all the catalogs. Can you please
simplify the assert to fail on generic reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
