rdblue commented on code in PR #7913: URL: https://github.com/apache/iceberg/pull/7913#discussion_r1351018901
########## core/src/main/java/org/apache/iceberg/catalog/BaseSessionCatalog.java: ########## @@ -30,8 +30,10 @@ import org.apache.iceberg.exceptions.NamespaceNotEmptyException; import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; +import org.apache.iceberg.view.View; +import org.apache.iceberg.view.ViewBuilder; -public abstract class BaseSessionCatalog implements SessionCatalog { +public abstract class BaseSessionCatalog implements SessionCatalog, ViewSessionCatalog { Review Comment: Yes, I think we should. And let's track down why RevAPI didn't complain! That seems dangerous. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org