Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2580156079 Thanks @Xuanwo! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

Xuanwo merged PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2580091025 I think this PR is ready to merge. @Fokko @Xuanwo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1908414237 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGET

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

gaborkaszab commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1908369593 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(T

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1904829176 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGETS $

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1904830435 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGET

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1904828898 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGETS $

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1904828726 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGETS $

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1904813642 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGET

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1904773431 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGETS $

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1904261495 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGET

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1902525180 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGETS $

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1902490200 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGET

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1902261165 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGETS $

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1902260652 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGETS $

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1901824596 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGET

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1901768298 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGETS $

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1901768298 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGETS $

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1901405319 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGET

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1901405319 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGET

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1901365957 ## cmake_modules/BuildUtils.cmake: ## @@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGETS $

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1901029911 ## api/iceberg/visibility.h: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900615479 ## cmake_modules/BuildUtils.cmake: ## @@ -201,23 +202,29 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGET

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900615479 ## cmake_modules/BuildUtils.cmake: ## @@ -201,23 +202,29 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGET

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900615479 ## cmake_modules/BuildUtils.cmake: ## @@ -201,23 +202,29 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGET

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900516441 ## cmake_modules/BuildUtils.cmake: ## @@ -201,23 +202,29 @@ function(ADD_ICEBERG_LIB LIB_NAME) PUBLIC "$") endif() -install(TARGETS $

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900516103 ## api/iceberg/visibility.h: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTIC

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900516042 ## api/iceberg/visibility.h: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTIC

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

lidavidm commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900474985 ## api/iceberg/visibility.h: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900363610 ## api/iceberg/visibility.h: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900365823 ## api/iceberg/visibility.h: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900365823 ## api/iceberg/visibility.h: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900363610 ## api/iceberg/visibility.h: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900361644 ## api/iceberg/visibility.h: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTIC

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900361184 ## cmake_modules/BuildUtils.cmake: ## @@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME) target_include_directories(${LIB_NAME}_static PRIVATE ${ARG_PRIVATE_INCL

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900360320 ## cmake_modules/BuildUtils.cmake: ## @@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME) target_include_directories(${LIB_NAME}_static PRIVATE ${ARG_PRIVATE_I

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900359799 ## api/iceberg/visibility.h: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900359799 ## api/iceberg/visibility.h: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900355716 ## api/iceberg/visibility.h: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTIC

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900350764 ## cmake_modules/BuildUtils.cmake: ## @@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME) target_include_directories(${LIB_NAME}_static PRIVATE ${ARG_PRIVATE_I

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900344597 ## cmake_modules/BuildUtils.cmake: ## @@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME) target_include_directories(${LIB_NAME}_static PRIVATE ${ARG_PRIVATE_INCL

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900339989 ## cmake_modules/BuildUtils.cmake: ## @@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME) target_include_directories(${LIB_NAME}_static PRIVATE ${ARG_PRIVATE_INCL

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900328737 ## cmake_modules/BuildUtils.cmake: ## @@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME) target_include_directories(${LIB_NAME}_static PRIVATE ${ARG_PRIVATE_I

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900328737 ## cmake_modules/BuildUtils.cmake: ## @@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME) target_include_directories(${LIB_NAME}_static PRIVATE ${ARG_PRIVATE_I

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900327762 ## cmake_modules/BuildUtils.cmake: ## @@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME) target_include_directories(${LIB_NAME}_static PRIVATE ${ARG_PRIVATE_INCL

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900327030 ## cmake_modules/ThirdpartyToolchain.cmake: ## @@ -0,0 +1,142 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900325544 ## cmake_modules/BuildUtils.cmake: ## @@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME) target_include_directories(${LIB_NAME}_static PRIVATE ${ARG_PRIVATE_I

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900309004 ## cmake_modules/BuildUtils.cmake: ## @@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME) target_include_directories(${LIB_NAME}_static PRIVATE ${ARG_PRIVATE_INCL

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900166523 ## cmake_modules/BuildUtils.cmake: ## @@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME) target_include_directories(${LIB_NAME}_static PRIVATE ${ARG_PRIVATE_I

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900073077 ## README.md: ## @@ -44,9 +61,14 @@ After installing the core libraries, you can build the examples: ```bash cd iceberg-cpp/example -mkdir build && cd build -cmake .. -D

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2566218953 Thanks @kou for your suggestion! Now the CMake implementation is greatly simplified. FYI, the installed directory looks like below: ``` ├── include/ │ ├── iceberg/ │ │ ├── p

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1899970387 ## src/CMakeLists.txt: ## @@ -15,5 +15,20 @@ # specific language governing permissions and limitations # under the License. +add_subdirectory(arrow) add_subdirectory(

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1899965461 ## example/CMakeLists.txt: ## @@ -22,10 +22,10 @@ project(example) set(CMAKE_CXX_STANDARD 20) -find_package(iceberg CONFIG REQUIRED) -find_package(puffin CONFIG REQUI

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1899930371 ## cmake_modules/ThirdpartyToolchain.cmake: ## @@ -0,0 +1,142 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1899929235 ## src/CMakeLists.txt: ## @@ -15,5 +15,20 @@ # specific language governing permissions and limitations # under the License. +add_subdirectory(arrow) add_subdirectory(

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1899927285 ## cmake_modules/ThirdpartyToolchain.cmake: ## @@ -0,0 +1,139 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1899827873 ## cmake_modules/ThirdpartyToolchain.cmake: ## @@ -0,0 +1,142 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

kou commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1899057489 ## cmake_modules/ThirdpartyToolchain.cmake: ## @@ -0,0 +1,142 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2563325643 This is ready for review now. Thanks @lidavidm and @zhjwpku for approval! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897986191 ## cmake_modules/ThirdpartyToolchain.cmake: ## @@ -0,0 +1,139 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897934087 ## src/CMakeLists.txt: ## @@ -15,5 +15,20 @@ # specific language governing permissions and limitations # under the License. +add_subdirectory(arrow) add_subdirectory(

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897934087 ## src/CMakeLists.txt: ## @@ -15,5 +15,20 @@ # specific language governing permissions and limitations # under the License. +add_subdirectory(arrow) add_subdirectory(

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

zhjwpku commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897865046 ## src/CMakeLists.txt: ## @@ -15,5 +15,20 @@ # specific language governing permissions and limitations # under the License. +add_subdirectory(arrow) add_subdirectory

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897676702 ## src/CMakeLists.txt: ## @@ -15,5 +15,20 @@ # specific language governing permissions and limitations # under the License. +add_subdirectory(arrow) add_subdirectory(

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

lidavidm commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897591862 ## src/CMakeLists.txt: ## @@ -15,5 +15,20 @@ # specific language governing permissions and limitations # under the License. +add_subdirectory(arrow) add_subdirector

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897586676 ## src/CMakeLists.txt: ## @@ -15,5 +15,20 @@ # specific language governing permissions and limitations # under the License. +add_subdirectory(arrow) add_subdirectory(

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897581776 ## cmake_modules/ThirdpartyToolchain.cmake: ## @@ -0,0 +1,139 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897581776 ## cmake_modules/ThirdpartyToolchain.cmake: ## @@ -0,0 +1,139 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

zhjwpku commented on PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2558785835 > @zhjwpku Yes, I am already working on simplifying it by integrating `FetchContent_declare` with `FIND_PACKAGE_ARGS`. They are still in my local copy and I'm polishing them. It is pretty e

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2558783070 @zhjwpku Yes, I am already working on simplifying it by integrating `FetchContent_declare` with `FIND_PACKAGE_ARGS`. They are still in my local copy and I'm polishing them. I'm too busy thes

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

zhjwpku commented on PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2558769771 This seems real complicated, ISTM that `find_package and FetchContent` mentioned by @lidavidm should be an easy way, I tried that in #13, maybe you can check that. -- This is an automate

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2543168693 Well, it seems that I cannot make the Windows CI happy. It complains unresolved Arrow symbols during linking. I think I need a Windows PC to debug it. -- This is an automated message from

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2530677420 That makes sense! Let me spend some time to simplify it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

pitrou commented on PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2527194639 > e.g. it seems we could integrate find_package and FetchContent more naturally and not rely on the pile of code Arrow uses That would certainly be preferrable. The "Arrow way" of hand

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

lidavidm commented on PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2526460512 e.g. it seems we could integrate find_package and FetchContent more naturally and not rely on the pile of code Arrow uses: https://stackoverflow.com/questions/73621403/cmake-integrating-fe

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1874613441 ## src/arrow/CMakeLists.txt: ## @@ -0,0 +1,66 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE f

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac commented on PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2525419398 I have added a `iceberg-arrow` library to opt in an Arrow-backed implementation in the future. I follow a similar pattern of arrow-cpp to manage third-party libraries. Let me know what you t

Re: [PR] Add iceberg_arrow library [iceberg-cpp]

zhjwpku commented on code in PR #6: URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1874599187 ## src/arrow/CMakeLists.txt: ## @@ -0,0 +1,66 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE

[PR] Add iceberg_arrow library [iceberg-cpp]

wgtmac opened a new pull request, #6: URL: https://github.com/apache/iceberg-cpp/pull/6 - Add a new library iceberg_arrow to leverage arrow-backed implementations (e.g. filesystem and parquet). - Add Apache Arrow 18.1.0 as a third-party dependency to libiceberg_arrow. -- This is an aut