wgtmac commented on code in PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1899929235
##########
src/CMakeLists.txt:
##########
@@ -15,5 +15,20 @@
# specific language governing permissions and limitations
# under the License.
+add_subdirectory(arrow)
add_subdirectory(core)
add_subdirectory(puffin)
+
+include(CMakePackageConfigHelpers)
+
+configure_package_config_file("${CMAKE_CURRENT_SOURCE_DIR}/config.cmake.in"
+
"${CMAKE_CURRENT_BINARY_DIR}/iceberg-config.cmake"
Review Comment:
I saw that both `<lowercasePackageName>-config.cmake` and
`<PackageName>Config.cmake` are acceptable. It seems that the official CMake
documentation uses a lot of the former style as examples and some package
managers (e.g. Conan) also use the former one. Therefore I follow the same
pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
