kou commented on code in PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900327762
##########
cmake_modules/BuildUtils.cmake:
##########
@@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME)
target_include_directories(${LIB_NAME}_static PRIVATE
${ARG_PRIVATE_INCLUDES})
endif()
- if(MSVC_TOOLCHAIN)
- set(LIB_NAME_STATIC ${LIB_NAME}_static)
- else()
- set(LIB_NAME_STATIC ${LIB_NAME})
- endif()
-
- set_target_properties(${LIB_NAME}_static PROPERTIES OUTPUT_NAME
${LIB_NAME_STATIC})
+ set_target_properties(${LIB_NAME}_static PROPERTIES OUTPUT_NAME
${LIB_NAME})
Review Comment:
> It is installed, but to a different location (bin vs lib)
>
> * C:/Users/runneradmin/AppData/Local/Temp/iceberg/bin/iceberg_arrow.dll
>
> * C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/iceberg_arrow.lib
This is expected.
Users use `lib/iceberg_arrow.lib` when they build their program.
Users use `bin/iceberg_arrow.dll` when they run their program.
> If I use `${LIB_NAME_STATIC}`, it will be
>
> *
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/iceberg_arrow_static.lib
>
>
> I don't know how to let `iceberg_arrow.dll` reference to
`iceberg_arrow_static.lib` but not the default `iceberg_arrow.lib`
If users use static library, users don't use `iceberg_arrow.dll`. Users use
only `iceberg_arrow_static.lib` for static linking.
If users use shared library, users use `lib/iceberg_arrow.lib` on building
and `bin/iceberg_arrow.dll` on running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
