wgtmac commented on code in PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897586676
##########
src/CMakeLists.txt:
##########
@@ -15,5 +15,20 @@
# specific language governing permissions and limitations
# under the License.
+add_subdirectory(arrow)
add_subdirectory(core)
add_subdirectory(puffin)
+
+include(CMakePackageConfigHelpers)
+
+configure_package_config_file("${CMAKE_CURRENT_SOURCE_DIR}/config.cmake.in"
+
"${CMAKE_CURRENT_BINARY_DIR}/iceberg-config.cmake"
+ INSTALL_DESTINATION
"${ICEBERG_INSTALL_CMAKEDIR}/Iceberg")
+
+write_basic_package_version_file(
+ "${CMAKE_CURRENT_BINARY_DIR}/iceberg-config-version.cmake"
+ COMPATIBILITY SameMajorVersion)
+
+install(FILES "${CMAKE_CURRENT_BINARY_DIR}/iceberg-config.cmake"
Review Comment:
FYI, the install directory (with only static library built) looks like below:
```
/tmp/iceberg/
├── lib/
│ ├── libarrow.a
│ ├── libiceberg_arrow.a
│ ├── libiceberg_core.a
│ ├── libiceberg_puffin.a
│ └── cmake/
│ ├── Iceberg/
│ │ ├── iceberg-arrow-targets.cmake
│ │ ├── iceberg-arrow-targets-debug.cmake
│ │ ├── iceberg-core-targets.cmake
│ │ ├── iceberg-core-targets-debug.cmake
│ │ ├── iceberg-puffin-targets.cmake
│ │ ├── iceberg-puffin-targets-debug.cmake
│ │ ├── iceberg-config.cmake
│ │ └── iceberg-config-version.cmake
├── include/
│ └── iceberg/
│ ├── puffin.h
│ ├── table.h
│ └── demo_arrow.h
└── share/
└── doc/
└── iceberg/
├── LICENSE
└── NOTICE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
