kou commented on code in PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900309004
##########
cmake_modules/BuildUtils.cmake:
##########
@@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME)
target_include_directories(${LIB_NAME}_static PRIVATE
${ARG_PRIVATE_INCLUDES})
endif()
- if(MSVC_TOOLCHAIN)
- set(LIB_NAME_STATIC ${LIB_NAME}_static)
- else()
- set(LIB_NAME_STATIC ${LIB_NAME})
- endif()
-
- set_target_properties(${LIB_NAME}_static PROPERTIES OUTPUT_NAME
${LIB_NAME_STATIC})
+ set_target_properties(${LIB_NAME}_static PROPERTIES OUTPUT_NAME
${LIB_NAME})
Review Comment:
The error log of it is
https://github.com/apache/iceberg-cpp/actions/runs/12505613514/job/34889235775#step:4:33
, right?
```text
The imported target "Iceberg::iceberg_arrow_shared" references the file
"C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/iceberg_arrow.lib"
but this file does not exist.
```
It seems that `.lib` for shared library isn't installed. It's strange.
`.lib` for shared library is installed by default.
Could you try reverting this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
