wgtmac commented on code in PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900350764
##########
cmake_modules/BuildUtils.cmake:
##########
@@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME)
target_include_directories(${LIB_NAME}_static PRIVATE
${ARG_PRIVATE_INCLUDES})
endif()
- if(MSVC_TOOLCHAIN)
- set(LIB_NAME_STATIC ${LIB_NAME}_static)
- else()
- set(LIB_NAME_STATIC ${LIB_NAME})
- endif()
-
- set_target_properties(${LIB_NAME}_static PROPERTIES OUTPUT_NAME
${LIB_NAME_STATIC})
+ set_target_properties(${LIB_NAME}_static PROPERTIES OUTPUT_NAME
${LIB_NAME})
Review Comment:
Ah, it seems working.
```
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/iceberg_vendored_arrow.lib
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/include/iceberg
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/include/iceberg/puffin.h
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/include/iceberg/table.h
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/bin/iceberg_core.dll
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/iceberg_core_static.lib
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/bin/iceberg_puffin.dll
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/iceberg_puffin_static.lib
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/iceberg_arrow.lib
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/bin/iceberg_arrow.dll
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/iceberg_arrow_static.lib
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/include/iceberg/arrow/demo_arrow.h
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/cmake/Iceberg/IcebergConfig.cmake
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/cmake/Iceberg/IcebergConfigVersion.cmake
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/cmake/Iceberg/IcebergTargets.cmake
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/cmake/Iceberg/IcebergTargets-debug.cmake
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/share/doc/Iceberg/LICENSE
-- Installing:
C:/Users/runneradmin/AppData/Local/Temp/iceberg/share/doc/Iceberg/NOTICE
...
CMake Error at
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/cmake/Iceberg/IcebergTargets.cmake:130
(message):
The imported target "Iceberg::iceberg_core_shared" references the file
-- Configuring incomplete, errors occurred!
"C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/iceberg_core.lib"
but this file does not exist. Possible reasons include:
* The file was deleted, renamed, or moved to another location.
* An install or uninstall procedure did not complete successfully.
* The installation package was faulty and contained
"C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/cmake/Iceberg/IcebergTargets.cmake"
but not all the files it references.
Call Stack (most recent call first):
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/cmake/Iceberg/IcebergConfig.cmake:99
(include)
CMakeLists.txt:25 (find_package)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
