kou commented on code in PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1901768298
##########
cmake_modules/BuildUtils.cmake:
##########
@@ -201,17 +202,26 @@ function(ADD_ICEBERG_LIB LIB_NAME)
PUBLIC
"$<BUILD_INTERFACE:${ARG_STATIC_LINK_LIBS}>")
endif()
- install(TARGETS ${LIB_NAME}_static ${INSTALL_IS_OPTIONAL}
- EXPORT ${LIB_NAME}_targets
+ install(TARGETS ${LIB_NAME}_static
+ EXPORT iceberg_targets
ARCHIVE DESTINATION ${INSTALL_ARCHIVE_DIR}
LIBRARY DESTINATION ${INSTALL_LIBRARY_DIR}
RUNTIME DESTINATION ${INSTALL_RUNTIME_DIR}
INCLUDES
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
endif()
- if(ARG_CMAKE_PACKAGE_NAME)
- iceberg_install_cmake_package(${ARG_CMAKE_PACKAGE_NAME}
${LIB_NAME}_targets)
+ # generate export header file
+ string(TOUPPER ${LIB_NAME} LIB_NAME_UPPER)
+ if(BUILD_SHARED)
+ generate_export_header(${LIB_NAME}_shared BASE_NAME ${LIB_NAME_UPPER})
+ target_compile_definitions(${LIB_NAME}_shared PUBLIC
${LIB_NAME}_shared_EXPORTS)
Review Comment:
https://github.com/apache/iceberg-cpp/actions/runs/12591221855/job/35094013478#step:3:422
```text
demo_puffin.obj : error LNK2019: unresolved external symbol
"__declspec(dllimport) public: virtual __cdecl iceberg::Puffin::~Puffin(void)"
(__imp_??1Puffin@iceberg@@UEAA@XZ) referenced in function "public: virtual
__cdecl iceberg::puffin::DemoPuffin::~DemoPuffin(void)"
(??1DemoPuffin@puffin@iceberg@@UEAA@XZ)
[D:\a\iceberg-cpp\iceberg-cpp\build\src\iceberg\puffin\iceberg_puffin_shared.vcxproj]
demo_puffin.obj : error LNK2019: unresolved external symbol
"__declspec(dllimport) public: __cdecl iceberg::Puffin::Puffin(void)"
(__imp_??0Puffin@iceberg@@QEAA@XZ) referenced in function "public: __cdecl
iceberg::puffin::DemoPuffin::DemoPuffin(void)"
(??0DemoPuffin@puffin@iceberg@@QEAA@XZ)
[D:\a\iceberg-cpp\iceberg-cpp\build\src\iceberg\puffin\iceberg_puffin_shared.vcxproj]
demo_puffin.obj : error LNK2019: unresolved external symbol
"__declspec(dllimport) public: __cdecl iceberg::Puffin::Puffin(class
iceberg::Puffin const &)" (__imp_??0Puffin@iceberg@@QEAA@AEBV01@@Z) referenced
in function "public: __cdecl iceberg::puffin::DemoPuffin::DemoPuffin(class
iceberg::puffin::DemoPuffin const &)"
(??0DemoPuffin@puffin@iceberg@@QEAA@AEBV012@@Z)
[D:\a\iceberg-cpp\iceberg-cpp\build\src\iceberg\puffin\iceberg_puffin_shared.vcxproj]
demo_puffin.obj : error LNK2019: unresolved external symbol
"__declspec(dllimport) public: class iceberg::Puffin & __cdecl
iceberg::Puffin::operator=(class iceberg::Puffin const &)"
(__imp_??4Puffin@iceberg@@QEAAAEAV01@AEBV01@@Z) referenced in function "public:
class iceberg::puffin::DemoPuffin & __cdecl
iceberg::puffin::DemoPuffin::operator=(class iceberg::puffin::DemoPuffin const
&)" (??4DemoPuffin@puffin@iceberg@@QEAAAEAV012@AEBV012@@Z)
[D:\a\iceberg-cpp\iceberg-cpp\build\src\iceberg\puffin\iceberg_puffin_shared.vcxproj]
```
OK. It's an implementation problem. We should remove this line. (Or we
should use `PRIVATE` not `PUBLIC`.)
`iceberg::Puffin` should exist in `libiceberg_core.dll` not
`libiceberg_puffin.dll`. Can we define `iceberg::Puffine` in
`libiceberg_core.dll` something like the following?
```diff
diff --git a/src/iceberg/demo_table.cc b/src/iceberg/demo_table.cc
index 9e46d7a..d960f1b 100644
--- a/src/iceberg/demo_table.cc
+++ b/src/iceberg/demo_table.cc
@@ -18,6 +18,7 @@
*/
#include "iceberg/demo_table.h"
+#include "iceberg/puffin.h"
namespace iceberg {
```
BTW, is it OK that `iceberg::Puffin` exists in `libiceberg_core.dll` not
`libiceberg_puffin.dll`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
