Re: [PR] feat: add manifest related structures [iceberg-cpp]

gty404 commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2082931928 ## src/iceberg/manifest_list.cc: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

[I] Feature request: make `blob` struct public [iceberg-rust]

dentiny opened a new issue, #1311: URL: https://github.com/apache/iceberg-rust/issues/1311 ### Is your feature request related to a problem or challenge? Hi team, recently I'm add self-implemented index structure into iceberg, because puffin file and blob is a container type, and is s

Re: [PR] feat: implement initial MemoryCatalog functionality with namespace and table support [iceberg-cpp]

gty404 commented on code in PR #80: URL: https://github.com/apache/iceberg-cpp/pull/80#discussion_r2082862088 ## src/iceberg/catalog/memory_catalog.h: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreemen

[PR] chore: define deletion vector type constant [iceberg-rust]

dentiny opened a new pull request, #1310: URL: https://github.com/apache/iceberg-rust/pull/1310 ## Which issue does this PR close? This PR adds deletion vector type constant (which is the counterpart for already-defined `APACHE_DATASKETCHES_THETA_V1`). Reference: https://iceberg.a

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

dentiny commented on PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#issuecomment-2868361247 The failed CI test doesn't seem to be related to my change: ``` ailures: test_drop_table stdout Error: Unexpected => Failure in doing io operation Sour

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2082813643 ## src/iceberg/manifest_list.h: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2082810322 ## src/iceberg/manifest_reader.h: ## @@ -26,13 +26,15 @@ #include #include "iceberg/file_reader.h" +#include "iceberg/iceberg_export.h" +#include "iceberg/type_fwd

Re: [PR] feat: add manifest related structures [iceberg-cpp]

zhjwpku commented on code in PR #91: URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2082809860 ## src/iceberg/manifest_reader.h: ## @@ -26,13 +26,15 @@ #include #include "iceberg/file_reader.h" +#include "iceberg/iceberg_export.h" +#include "iceberg/type_fwd

Re: [PR] Core, OpenAPI: Add commit timestamp to CommitReport [iceberg]

manuzhang commented on code in PR #12990: URL: https://github.com/apache/iceberg/pull/12990#discussion_r2082620925 ## open-api/rest-catalog-open-api.yaml: ## @@ -3775,6 +3775,9 @@ components: properties: table-name: type: string +timestamp-mill

Re: [PR] chore(deps): Bump ring from 0.17.9 to 0.17.14 in /bindings/python [iceberg-rust]

liurenjie1024 merged PR #1309: URL: https://github.com/apache/iceberg-rust/pull/1309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] feat: add name mapping [iceberg-cpp]

zhjwpku commented on code in PR #93: URL: https://github.com/apache/iceberg-cpp/pull/93#discussion_r2082800454 ## src/iceberg/util/checked_cast_internal.h: ## @@ -0,0 +1,61 @@ +/* Review Comment: Should we install this header by removing the internal suffix? I don't see it

Re: [I] PartitionSpec.Builder::identity should be public [iceberg]

RussellSpitzer commented on issue #12943: URL: https://github.com/apache/iceberg/issues/12943#issuecomment-2867796035 Why does it matter that the names don't match? Shouldn't only the fieldId matter? I would also think that if we did care about the name we would just make sure any a

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

dentiny commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082761721 ## crates/iceberg/src/error.rs: ## @@ -28,6 +28,9 @@ pub type Result = std::result::Result; #[derive(Clone, Copy, Debug, PartialEq, Eq)] #[non_exhaustive] pub e

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

dentiny commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082760864 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -172,6 +179,13 @@ impl<'a> SnapshotProduceAction<'a> { // Write manifest file for added data files and re

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

dentiny commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082750070 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -129,6 +129,13 @@ impl<'a> SnapshotProduceAction<'a> { data_files: impl IntoIterator, ) -> Resul

Re: [PR] Flink 2.0: Remove the JUnit4 dependency [iceberg]

JeonDaehong commented on PR #13021: URL: https://github.com/apache/iceberg/pull/13021#issuecomment-2868212864 @nastra Hello, I've reopened the PR after incorporating the feedback you provided. Thank you! -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

dentiny commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082749568 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -129,6 +129,13 @@ impl<'a> SnapshotProduceAction<'a> { data_files: impl IntoIterator, ) -> Resul

[PR] Flink 2.0: Remove the JUnit4 dependency [iceberg]

JeonDaehong opened a new pull request, #13021: URL: https://github.com/apache/iceberg/pull/13021 Hello, Regarding issue https://github.com/apache/iceberg/issues/12937, I am submitting a PR for v2.0 first. I have removed the MiniClusterWithClientResource class, which was still

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

Xuanwo commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082748345 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -129,6 +129,13 @@ impl<'a> SnapshotProduceAction<'a> { data_files: impl IntoIterator, ) -> Result

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

Xuanwo commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082752488 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -129,6 +129,13 @@ impl<'a> SnapshotProduceAction<'a> { data_files: impl IntoIterator, ) -> Result

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

Xuanwo commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082752305 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -129,6 +129,13 @@ impl<'a> SnapshotProduceAction<'a> { data_files: impl IntoIterator, ) -> Result

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

Xuanwo commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082750204 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -172,6 +179,13 @@ impl<'a> SnapshotProduceAction<'a> { // Write manifest file for added data files and ret

Re: [PR] Materialized View Spec [iceberg]

yyanyy commented on code in PR #11041: URL: https://github.com/apache/iceberg/pull/11041#discussion_r2082737494 ## format/view-spec.md: ## @@ -160,6 +179,57 @@ Each entry in `version-log` is a struct with the following fields: | _required_ | `timestamp-ms` | Timestamp when th

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

dentiny commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082749568 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -129,6 +129,13 @@ impl<'a> SnapshotProduceAction<'a> { data_files: impl IntoIterator, ) -> Resul

Re: [PR] [Spark]Add max files rewrite option for RewriteAction [iceberg]

coderfender commented on code in PR #12824: URL: https://github.com/apache/iceberg/pull/12824#discussion_r2082637481 ## core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFilePlanner.java: ## @@ -199,30 +214,48 @@ protected long defaultTargetFileSize() { public FileR

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

github-actions[bot] commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2868134939 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Flink 2.0: Remove the JUnit4 dependency [iceberg]

JeonDaehong closed pull request #13016: Flink 2.0: Remove the JUnit4 dependency URL: https://github.com/apache/iceberg/pull/13016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Core: use ReachableFileCleanup when table has discontinuous snapshots [iceberg]

github-actions[bot] commented on PR #12261: URL: https://github.com/apache/iceberg/pull/12261#issuecomment-2868134773 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Flink: Add DynamicRecord / DynamicRecordInternal / DynamicRecordInternalSerializer [iceberg]

mxm commented on code in PR #12996: URL: https://github.com/apache/iceberg/pull/12996#discussion_r2081820819 ## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordInternal.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Added support for evolving the partition of the table [iceberg]

github-actions[bot] commented on PR #12723: URL: https://github.com/apache/iceberg/pull/12723#issuecomment-2868135010 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [I] The source artifacts provided with GitHub releases are not buildable. [iceberg]

github-actions[bot] commented on issue #11505: URL: https://github.com/apache/iceberg/issues/11505#issuecomment-2868134728 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [PR] feat: Add initial support for create table CLI through json schema [iceberg-go]

kevinjqliu commented on code in PR #424: URL: https://github.com/apache/iceberg-go/pull/424#discussion_r2082623123 ## cmd/iceberg/main.go: ## @@ -79,7 +79,9 @@ Options: --warehouse TEXT specify the warehouse to use --config TEXT specify the path to the configuration

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

github-actions[bot] closed pull request #12695: AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory URL: https://github.com/apache/iceberg/pull/12695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] fix: validate that source column type is primitive for partition spec [iceberg-rust]

kevinjqliu commented on PR #1285: URL: https://github.com/apache/iceberg-rust/pull/1285#issuecomment-2868110690 `checkCompatibility` is called on the [`PartitionSpec`'s `build` method](https://github.com/apache/iceberg/blob/97c0e136b8021058897cab7539e3ef89ce5a0341/api/src/main/java/org/apach

Re: [PR] Flink 2.0: Remove the JUnit4 dependency [iceberg]

JeonDaehong commented on code in PR #13016: URL: https://github.com/apache/iceberg/pull/13016#discussion_r2082646687 ## data/src/test/java/org/apache/iceberg/data/GenericAppenderHelper.java: ## @@ -122,13 +107,13 @@ public DataFile writeFile(StructLike partition, List records)

Re: [PR] Flink 2.0: Remove the JUnit4 dependency [iceberg]

JeonDaehong commented on code in PR #13016: URL: https://github.com/apache/iceberg/pull/13016#discussion_r2082646283 ## flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergSink.java: ## @@ -421,8 +421,10 @@ void testOperatorsUidNameWitUidSuffix() throws Excep

Re: [PR] Flink 2.0: Remove the JUnit4 dependency [iceberg]

JeonDaehong commented on PR #13016: URL: https://github.com/apache/iceberg/pull/13016#issuecomment-2868105882 > @JeonDaehong Please update the PR title to `Flink 2.0: Remove the JUnit4 dependency` I have completed the changes !! -- This is an automated message from the Apache Git

Re: [PR] feat: Add initial support for create table CLI through json schema [iceberg-go]

kevinjqliu commented on code in PR #424: URL: https://github.com/apache/iceberg-go/pull/424#discussion_r2082649433 ## cmd/iceberg/main.go: ## @@ -79,7 +79,9 @@ Options: --warehouse TEXT specify the warehouse to use --config TEXT specify the path to the configuration

Re: [PR] feat: Add initial support for create table CLI through json schema [iceberg-go]

lliangyu-lin commented on code in PR #424: URL: https://github.com/apache/iceberg-go/pull/424#discussion_r2082642006 ## cmd/iceberg/main.go: ## @@ -79,7 +79,9 @@ Options: --warehouse TEXT specify the warehouse to use --config TEXT specify the path to the configurati

Re: [PR] feat: Add initial support for create table CLI through json schema [iceberg-go]

lliangyu-lin commented on code in PR #424: URL: https://github.com/apache/iceberg-go/pull/424#discussion_r2082642006 ## cmd/iceberg/main.go: ## @@ -79,7 +79,9 @@ Options: --warehouse TEXT specify the warehouse to use --config TEXT specify the path to the configurati

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

jonathanc-n commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082615963 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -129,6 +129,13 @@ impl<'a> SnapshotProduceAction<'a> { data_files: impl IntoIterator, ) -> R

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

dentiny commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082611227 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -129,6 +129,13 @@ impl<'a> SnapshotProduceAction<'a> { data_files: impl IntoIterator, ) -> Resul

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

dentiny commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082607971 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -129,6 +129,13 @@ impl<'a> SnapshotProduceAction<'a> { data_files: impl IntoIterator, ) -> Resul

Re: [PR] chore: Add assertion for empty data files for append action [iceberg-rust]

jonathanc-n commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082494488 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -129,6 +129,13 @@ impl<'a> SnapshotProduceAction<'a> { data_files: impl IntoIterator, ) -> R

[PR] chore(deps): Bump ring from 0.17.9 to 0.17.14 in /bindings/python [iceberg-rust]

dependabot[bot] opened a new pull request, #1309: URL: https://github.com/apache/iceberg-rust/pull/1309 Bumps [ring](https://github.com/briansmith/ring) from 0.17.9 to 0.17.14. Changelog Sourced from https://github.com/briansmith/ring/blob/main/RELEASES.md";>ring's changelog.

Re: [PR] [SPARK] Fix add_files type conversion exception and incorrect partition value when handling null partitions [iceberg]

yyanyy commented on code in PR #12886: URL: https://github.com/apache/iceberg/pull/12886#discussion_r2082578755 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -1268,6 +1323,23 @@ private void createCompositePar

Re: [PR] Spec: Clarify behavior of special geo objects for lower/upper bounds [iceberg]

szehon-ho commented on PR #12956: URL: https://github.com/apache/iceberg/pull/12956#issuecomment-2867988213 Merged to master, thanks for all review! Reference: vote thread: https://lists.apache.org/thread/g7rz2kt12ytd5j2xnbdlk696cxm0d3s2 -- This is an automated message from the Apac

Re: [PR] Spec: Clarify behavior of special geo objects for lower/upper bounds [iceberg]

szehon-ho merged PR #12956: URL: https://github.com/apache/iceberg/pull/12956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] feat: Add initial support for create table CLI through json schema [iceberg-go]

lliangyu-lin commented on code in PR #424: URL: https://github.com/apache/iceberg-go/pull/424#discussion_r2082528886 ## cmd/iceberg/main.go: ## @@ -79,7 +79,9 @@ Options: --warehouse TEXT specify the warehouse to use --config TEXT specify the path to the configurati

Re: [PR] feat: Add initial support for create table CLI through json schema [iceberg-go]

lliangyu-lin commented on code in PR #424: URL: https://github.com/apache/iceberg-go/pull/424#discussion_r2082528886 ## cmd/iceberg/main.go: ## @@ -79,7 +79,9 @@ Options: --warehouse TEXT specify the warehouse to use --config TEXT specify the path to the configurati

Re: [PR] Update ADLS implementation status [iceberg]

kevinjqliu merged PR #13020: URL: https://github.com/apache/iceberg/pull/13020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

[PR] Update ADLS implementation status [iceberg]

mrcnc opened a new pull request, #13020: URL: https://github.com/apache/iceberg/pull/13020 Many implementations support Azure Data Lake Storage so I've updated the status to reflect the current state -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

kevinjqliu merged PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [I] Clarify Error Logs for GCS Directory/Object Conflicts [iceberg-python]

kevinjqliu commented on issue #1952: URL: https://github.com/apache/iceberg-python/issues/1952#issuecomment-2867856930 hmmm. [this](https://github.com/apache/arrow/blob/067fd2a2c6e54d33b9ae8a3324f59bebe960d485/cpp/src/arrow/filesystem/gcsfs.cc#L351-L360) is saying that the `location` is a

Re: [PR] Core, OpenAPI: Add commit timestamp to CommitReport [iceberg]

flyrain commented on code in PR #12990: URL: https://github.com/apache/iceberg/pull/12990#discussion_r2082123884 ## open-api/rest-catalog-open-api.yaml: ## @@ -3775,6 +3775,9 @@ components: properties: table-name: type: string +timestamp-millis

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

kevinjqliu commented on PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#issuecomment-2867838923 Thanks @petern48 for the contribution! Always love docs improvements :) Note the change wont show up in https://py.iceberg.apache.org/ until we run the github action, whi

Re: [I] [Docs] Improve contributing instructions [iceberg-python]

kevinjqliu closed issue #1964: [Docs] Improve contributing instructions URL: https://github.com/apache/iceberg-python/issues/1964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

kevinjqliu commented on code in PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#discussion_r2082462531 ## mkdocs/docs/contributing.md: ## @@ -37,7 +37,7 @@ The PyIceberg Project is hosted on GitHub at

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

kevinjqliu commented on code in PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#discussion_r2082464664 ## mkdocs/docs/contributing.md: ## @@ -48,7 +48,7 @@ python -m venv ./venv source ./venv/bin/activate ``` -To get started, you can run `make install`, whi

Re: [PR] Spec: Add details on GZIP compressed metadata files [iceberg]

kevinjqliu commented on PR #12598: URL: https://github.com/apache/iceberg/pull/12598#issuecomment-2867823819 I'm +1 to merging this but deferring to @emkornfield Strictly basing off the PR guidelines [here](https://iceberg.apache.org/contribute/?h=vote#merging-pull-requests), I supp

Re: [PR] feat: Add initial support for create table CLI through json schema [iceberg-go]

kevinjqliu commented on code in PR #424: URL: https://github.com/apache/iceberg-go/pull/424#discussion_r2082443752 ## cmd/iceberg/main.go: ## @@ -79,7 +79,9 @@ Options: --warehouse TEXT specify the warehouse to use --config TEXT specify the path to the configuration

Re: [PR] feat: Add `IndexByName` and `IndexById` to Namemapping [iceberg-rust]

jonathanc-n commented on PR #1299: URL: https://github.com/apache/iceberg-rust/pull/1299#issuecomment-2867738652 @jdockerty @liurenjie1024 Thanks for the reviews. Should be fixed now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] feat: Add `IndexByName` and `IndexById` to Namemapping [iceberg-rust]

jonathanc-n commented on code in PR #1299: URL: https://github.com/apache/iceberg-rust/pull/1299#discussion_r2082404424 ## crates/iceberg/src/spec/name_mapping/mod.rs: ## @@ -79,15 +120,188 @@ impl MappedField { } /// Get a reference to the field mapping for any chil

Re: [PR] Core: Enhance remove snapshots efficiency by executing them in bulk [iceberg]

amogh-jahagirdar commented on code in PR #12670: URL: https://github.com/apache/iceberg/pull/12670#discussion_r2081810930 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1450,6 +1452,10 @@ private Builder rewriteSnapshotsInternal(Collection idsToRemove, bool

Re: [PR] fix: incorrectly added statement could cause deadlock [iceberg-rust]

sdd commented on PR #1306: URL: https://github.com/apache/iceberg-rust/pull/1306#issuecomment-2867456974 @liurenjie1024 @Xuanwo: please review this tiny bug fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] support all_entries in pyiceberg [iceberg-python]

soumya-ghosh commented on PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#issuecomment-2867718906 @amitgilad3 @Fokko @kevinjqliu Let's get this PR to completion to complete remaining metadata tables. -- This is an automated message from the Apache Git Service. To res

Re: [PR] feat: Add initial support for create table CLI through json schema [iceberg-go]

lliangyu-lin commented on code in PR #424: URL: https://github.com/apache/iceberg-go/pull/424#discussion_r2082267868 ## cmd/iceberg/main.go: ## @@ -79,7 +79,9 @@ Options: --warehouse TEXT specify the warehouse to use --config TEXT specify the path to the configurati

Re: [PR] Fix DayTransform [iceberg-go]

kevinjqliu commented on code in PR #423: URL: https://github.com/apache/iceberg-go/pull/423#discussion_r2082114997 ## transforms.go: ## @@ -720,7 +720,7 @@ func (t DayTransform) MarshalText() ([]byte, error) { func (DayTransform) String() string { return "day" } -func (DayT

Re: [PR] feat: Add initial support for create table CLI through json schema [iceberg-go]

lliangyu-lin commented on code in PR #424: URL: https://github.com/apache/iceberg-go/pull/424#discussion_r2082267868 ## cmd/iceberg/main.go: ## @@ -79,7 +79,9 @@ Options: --warehouse TEXT specify the warehouse to use --config TEXT specify the path to the configurati

Re: [PR] fix(transforms): DayTransform [iceberg-go]

zeroshade commented on code in PR #423: URL: https://github.com/apache/iceberg-go/pull/423#discussion_r2082256764 ## transforms.go: ## @@ -720,7 +720,7 @@ func (t DayTransform) MarshalText() ([]byte, error) { func (DayTransform) String() string { return "day" } -func (DayTr

Re: [PR] Materialized View Spec [iceberg]

hashhar commented on code in PR #11041: URL: https://github.com/apache/iceberg/pull/11041#discussion_r2080996777 ## format/view-spec.md: ## @@ -42,12 +42,28 @@ An atomic swap of one view metadata file for another provides the basis for maki Writers create view metadata files

Re: [PR] Flink: Support compact in iceberg sink v2 [iceberg]

Guosmilesmile commented on PR #12979: URL: https://github.com/apache/iceberg/pull/12979#issuecomment-2867501927 @mxm Thanks for the review. The original `RewriteDataFilesConfig` was a bit rigid, so I made some modifications to it. > I wonder whether we could even get rid of the ha

Re: [PR] Revert "Spark 4.0 integration" [iceberg]

huaxingao commented on PR #13006: URL: https://github.com/apache/iceberg/pull/13006#issuecomment-2867438300 Thank you all very much! @amogh-jahagirdar @wypoon @pan3793 @manuzhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Core: Fix a cast that is too narrow [iceberg]

angelo-DNAStack commented on PR #12743: URL: https://github.com/apache/iceberg/pull/12743#issuecomment-2867181389 Just wanted to check in and see if there was anything further I should do for this PR? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] fix: incorrectly added statement could cause deadlock [iceberg-rust]

sdd closed pull request #1306: fix: incorrectly added statement could cause deadlock URL: https://github.com/apache/iceberg-rust/pull/1306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] fix(transforms): DayTransform [iceberg-go]

kevinjqliu commented on code in PR #423: URL: https://github.com/apache/iceberg-go/pull/423#discussion_r2082170395 ## transforms.go: ## @@ -720,7 +720,7 @@ func (t DayTransform) MarshalText() ([]byte, error) { func (DayTransform) String() string { return "day" } -func (DayT

Re: [I] Issue during Upsert [iceberg-python]

kevinjqliu commented on issue #1759: URL: https://github.com/apache/iceberg-python/issues/1759#issuecomment-2867391759 @deepika094 would be great to post the stacktrace to help debug further. Let's create a new issue since the problem seems to be different from the current one -- This i

Re: [PR] fix(transforms): DayTransform [iceberg-go]

jhump commented on code in PR #423: URL: https://github.com/apache/iceberg-go/pull/423#discussion_r2082160512 ## transforms.go: ## @@ -720,7 +720,7 @@ func (t DayTransform) MarshalText() ([]byte, error) { func (DayTransform) String() string { return "day" } -func (DayTransf

Re: [PR] Core: Support incremental compute for partition stats [iceberg]

ajantha-bhat commented on PR #12629: URL: https://github.com/apache/iceberg/pull/12629#issuecomment-2867314558 I have updated the PR with just one interface (as a new commit) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Catalog: Add BigQuery Metastore Catalog Support [iceberg]

talatuyarer commented on code in PR #12808: URL: https://github.com/apache/iceberg/pull/12808#discussion_r2082102992 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,374 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Flink: Support compact in iceberg sink v2 [iceberg]

Guosmilesmile commented on code in PR #12979: URL: https://github.com/apache/iceberg/pull/12979#discussion_r2082148669 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/LockFactoryCreator.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Support compact in iceberg sink v2 [iceberg]

Guosmilesmile commented on code in PR #12979: URL: https://github.com/apache/iceberg/pull/12979#discussion_r2082149052 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/RewriteDataFilesConfig.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Sof

Re: [PR] fix(table) getPartitionRecord to use field ID rather than field name [iceberg-go]

zeroshade commented on PR #427: URL: https://github.com/apache/iceberg-go/pull/427#issuecomment-2867354420 > Perhaps we can add a test for https://github.com/apache/iceberg-go/issues/404, similar to this comment https://github.com/apache/iceberg-go/issues/404#issuecomment-2851945226

Re: [PR] Flink: Support compact in iceberg sink v2 [iceberg]

Guosmilesmile commented on code in PR #12979: URL: https://github.com/apache/iceberg/pull/12979#discussion_r2082144652 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/FlinkWriteOptions.java: ## @@ -81,6 +81,9 @@ private FlinkWriteOptions() {} public static final C

Re: [PR] Fix DayTransform [iceberg-go]

zeroshade commented on code in PR #423: URL: https://github.com/apache/iceberg-go/pull/423#discussion_r2082140394 ## transforms.go: ## @@ -720,7 +720,7 @@ func (t DayTransform) MarshalText() ([]byte, error) { func (DayTransform) String() string { return "day" } -func (DayTr

Re: [PR] fix(table) getPartitionRecord to use field ID rather than field name [iceberg-go]

zeroshade commented on code in PR #427: URL: https://github.com/apache/iceberg-go/pull/427#discussion_r2082119647 ## manifest.go: ## @@ -735,6 +739,7 @@ func (c *ManifestReader) ReadEntry() (ManifestEntry, error) { tmp.inherit(c.file) if fieldToIDMap, ok := tmp.

Re: [PR] Spark: Migrate Spark 3.4 SparkTestBaseWithCatalog related tests including refactoring Spark 3.5 tests [iceberg]

tomtongue commented on code in PR #13015: URL: https://github.com/apache/iceberg/pull/13015#discussion_r2082039865 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java: ## @@ -43,7 +44,9 @@ import org.apache.spark.sql.connector.wr

Re: [PR] Basic version of expireSnapshots operation. [iceberg-go]

kevinjqliu commented on PR #401: URL: https://github.com/apache/iceberg-go/pull/401#issuecomment-2867338414 > currently, the snapshots field of the produced metadata file looks ok (expired snapshots are not there), but the snapshot-log field still contains entries for every operation since

[PR] Fix predicates not matching the Arrow type of columns read from parquet files [iceberg-rust]

phillipleblanc opened a new pull request, #1308: URL: https://github.com/apache/iceberg-rust/pull/1308 ## Which issue does this PR close? - Closes #1307 ## What changes are included in this PR? I check the type of the literal scalar against the value we read from the par

Re: [PR] feat: Add initial support for create table CLI through json schema [iceberg-go]

kevinjqliu commented on code in PR #424: URL: https://github.com/apache/iceberg-go/pull/424#discussion_r2082107117 ## cmd/iceberg/main.go: ## @@ -79,7 +79,9 @@ Options: --warehouse TEXT specify the warehouse to use --config TEXT specify the path to the configuration

Re: [PR] Spark: Migrate Spark 3.4 SparkTestBaseWithCatalog related tests including refactoring Spark 3.5 tests [iceberg]

tomtongue commented on code in PR #13015: URL: https://github.com/apache/iceberg/pull/13015#discussion_r2082039865 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java: ## @@ -43,7 +44,9 @@ import org.apache.spark.sql.connector.wr

Re: [I] Consider Using object_store as IO Abstraction [iceberg-rust]

alamb commented on issue #172: URL: https://github.com/apache/iceberg-rust/issues/172#issuecomment-2867240478 > > In other words, this allows `opendal` and `object_store` to work well together, regardless of which one the user is currently using. > > I'll look into this approach further.

Re: [PR] Spark: Migrate Spark 3.4 SparkTestBaseWithCatalog related tests including refactoring Spark 3.5 tests [iceberg]

tomtongue commented on code in PR #13015: URL: https://github.com/apache/iceberg/pull/13015#discussion_r2082039865 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java: ## @@ -43,7 +44,9 @@ import org.apache.spark.sql.connector.wr

Re: [PR] [Spark]Add max files rewrite option for RewriteAction [iceberg]

coderfender commented on code in PR #12824: URL: https://github.com/apache/iceberg/pull/12824#discussion_r2082047278 ## core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFilePlanner.java: ## @@ -199,30 +214,48 @@ protected long defaultTargetFileSize() { public FileR

Re: [PR] Spark: Migrate Spark 3.4 SparkTestBaseWithCatalog related tests including refactoring Spark 3.5 tests [iceberg]

tomtongue commented on code in PR #13015: URL: https://github.com/apache/iceberg/pull/13015#discussion_r2082039865 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java: ## @@ -43,7 +44,9 @@ import org.apache.spark.sql.connector.wr

[PR] Spark: Fix flaky tests due to socket bind failure [iceberg]

manuzhang opened a new pull request, #13017: URL: https://github.com/apache/iceberg/pull/13017 Closes #12009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Flink: Add DynamicRecord / DynamicRecordInternal / DynamicRecordInternalSerializer [iceberg]

mxm commented on PR #12996: URL: https://github.com/apache/iceberg/pull/12996#issuecomment-2867164738 (Spark compile failed in build) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Core: Support incremental compute for partition stats [iceberg]

ajantha-bhat commented on PR #12629: URL: https://github.com/apache/iceberg/pull/12629#issuecomment-2867156263 @deniskuzZ: > We can work around it with removePartitionStatistics and then compute, but that would create 2 snapshots, not sure if that is a good approach. Iceberg

Re: [PR] I would like to request a PR for resolving issue 12937 by removing the JUnit4 dependency from the Flink 2.0 version. [iceberg]

tomtongue commented on code in PR #13016: URL: https://github.com/apache/iceberg/pull/13016#discussion_r2081986059 ## flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergSink.java: ## @@ -421,8 +421,10 @@ void testOperatorsUidNameWitUidSuffix() throws Excepti

Re: [PR] I would like to request a PR for resolving issue 12937 by removing the JUnit4 dependency from the Flink 2.0 version. [iceberg]

manuzhang commented on PR #13016: URL: https://github.com/apache/iceberg/pull/13016#issuecomment-2867153346 @JeonDaehong Please update the PR title to `Flink 2.0: Remove the JUnit4 dependency` -- This is an automated message from the Apache Git Service. To respond to the message, please

  1   2   >