Guosmilesmile commented on PR #12979: URL: https://github.com/apache/iceberg/pull/12979#issuecomment-2867501927
@mxm Thanks for the review. The original `RewriteDataFilesConfig` was a bit rigid, so I made some modifications to it. > I wonder whether we could even get rid of the hardcoded options and translation code, and instead lookup the options dynamically based on a prefix. The drawback of this would be, that the options could easily change if we rename a builder method, which might not be ideal. There are three types of settings for RewriteDataFiles: rewrite config, schedule, and a dynamic rewriteOptions map. I kept the original way for rewrite config and schedule, and instead use the options dynamically based on a prefix for the dynamic rewriteOptions map. Like use `flink-maintenance.rewrite.max-file-group-size-bytes` wil be handle to `max-file-group-size-bytes` to after. Additionally, the entry point now only accepts a map and filters out keys with the prefix flink-maintenance.rewrite., ensuring that the key names used after remove the prefix from top to bottom (from the Flink module to the Iceberg core) remain consistent. > I just wonder about the mapping of the SQL options to the actual builder. We should make sure to test the translation. As for the SQL options, because `JdbcLockFactory` reuses `JdbcClientPool` from the core package, whose constructor accepts a Map<String, String> props, I retained the pass-through approach here. These are some of my preliminary thoughts on this issue. If you have better suggestions, please feel free to share them, and I will provide feedback as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
