amogh-jahagirdar commented on code in PR #12670:
URL: https://github.com/apache/iceberg/pull/12670#discussion_r2081810930
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1450,6 +1452,10 @@ private Builder
rewriteSnapshotsInternal(Collection<Long> idsToRemove, boolean s
}
}
+ if (!snapshotIdsToRemove.isEmpty()) {
+ changes.add(new MetadataUpdate.RemoveSnapshots(snapshotIdsToRemove));
Review Comment:
@ajantha-bhat check out this thread
https://github.com/apache/iceberg/pull/12670#discussion_r2017577925
Essentially the protocol was always `RemoveSnapshots` (servers were always
handling this kind of message), and we're not deviating from that.
`RemoveSnapshot` was just an internal in-memory representation. Let me know if
that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
