lliangyu-lin commented on code in PR #424:
URL: https://github.com/apache/iceberg-go/pull/424#discussion_r2082642006
##########
cmd/iceberg/main.go:
##########
@@ -79,7 +79,9 @@ Options:
--warehouse TEXT specify the warehouse to use
--config TEXT specify the path to the configuration file
--description TEXT specify a description for the namespace
- --location-uri TEXT specify a location URI for the namespace`
+ --location-uri TEXT specify a location URI for the namespace
+ --schema TEXT specify table schema in json (for create table use only)
+ Ex:
[{"name":"id","type":"int","required":false,"doc":"unique id"}]`
Review Comment:
> should this be TEXT or JSON?
Goot point, I think JSON make sense. Let me update that
> also does the Ex:... part show up in usage?
Yes, this is what shows up when I ran `go run . -h`. Definitely feel like
the formatting could be improved, but I think could be fixed later.
```
Options:
-h --help show this help messages and exit
--catalog TEXT specify the catalog type [default: rest]
--uri TEXT specify the catalog URI
--output TYPE output type (json/text) [default: text]
--credential TEXT specify credentials for the catalog
--warehouse TEXT specify the warehouse to use
--config TEXT specify the path to the configuration file
--description TEXT specify a description for the namespace
--location-uri TEXT specify a location URI for the namespace
--schema TEXT specify table schema in json (for create table use
only)
Ex:
[{"name":"id","type":"int","required":false,"doc":"unique id"}]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
