jonathanc-n commented on code in PR #1301: URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082615963
########## crates/iceberg/src/transaction/snapshot.rs: ########## @@ -129,6 +129,13 @@ impl<'a> SnapshotProduceAction<'a> { data_files: impl IntoIterator<Item = DataFile>, ) -> Result<&mut Self> { let data_files: Vec<DataFile> = data_files.into_iter().collect(); + if data_files.is_empty() { Review Comment: Yes that makes sense, `InvalidArgument` or maybe `InvalidInput` is more intuitive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org