kevinjqliu commented on code in PR #424:
URL: https://github.com/apache/iceberg-go/pull/424#discussion_r2082623123
##########
cmd/iceberg/main.go:
##########
@@ -79,7 +79,9 @@ Options:
--warehouse TEXT specify the warehouse to use
--config TEXT specify the path to the configuration file
--description TEXT specify a description for the namespace
- --location-uri TEXT specify a location URI for the namespace`
+ --location-uri TEXT specify a location URI for the namespace
+ --schema TEXT specify table schema in json (for create table use only)
+ Ex:
[{"name":"id","type":"int","required":false,"doc":"unique id"}]`
Review Comment:
should this be TEXT or JSON?
##########
cmd/iceberg/main.go:
##########
@@ -79,7 +79,9 @@ Options:
--warehouse TEXT specify the warehouse to use
--config TEXT specify the path to the configuration file
--description TEXT specify a description for the namespace
- --location-uri TEXT specify a location URI for the namespace`
+ --location-uri TEXT specify a location URI for the namespace
+ --schema TEXT specify table schema in json (for create table use only)
+ Ex:
[{"name":"id","type":"int","required":false,"doc":"unique id"}]`
Review Comment:
also does the `Ex:...` part show up in usage? all the other options have 1
line only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
