kevinjqliu commented on PR #1285: URL: https://github.com/apache/iceberg-rust/pull/1285#issuecomment-2868110690
`checkCompatibility` is called on the [`PartitionSpec`'s `build` method](https://github.com/apache/iceberg/blob/97c0e136b8021058897cab7539e3ef89ce5a0341/api/src/main/java/org/apache/iceberg/PartitionSpec.java#L618). Maybe we should do the same for `check_transform_compatibility`. Currently its only called in [`add_unbound_field` ](https://github.com/apache/iceberg-rust/blob/513376cb04b899edf457918c3852a786a292071c/crates/iceberg/src/spec/partition.rs#L431) from the original comment """ This is currently not guranteed, neither by deserialization nor for add_unbound_field. At least adding a void transform can result in complex types. """ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
