Re: [PR] feat: add json serialization for schema [iceberg-cpp]

2025-04-09 Thread via GitHub
wgtmac commented on code in PR #65: URL: https://github.com/apache/iceberg-cpp/pull/65#discussion_r2036568131 ## src/iceberg/util/macro_internal.h: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-09 Thread via GitHub
gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2036516995 ## src/iceberg/type_fwd.h: ## @@ -101,6 +101,7 @@ class StructLike; class TableMetadata; enum class TransformType; class TransformFunction; +struct TransformSpec; Re

Re: [PR] feat: sort field/order json serialize/deserialization [iceberg-cpp]

2025-04-09 Thread via GitHub
wgtmac commented on code in PR #64: URL: https://github.com/apache/iceberg-cpp/pull/64#discussion_r2036602038 ## src/iceberg/json_internal.cc: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-09 Thread via GitHub
lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2036600412 ## test/transform_test.cc: ## @@ -25,30 +25,48 @@ #include #include +#include "iceberg/transform/transform_function.h" +#include "iceberg/type.h" #include "iceb

Re: [PR] feat: sort field/order json serialize/deserialization [iceberg-cpp]

2025-04-09 Thread via GitHub
lidavidm commented on code in PR #64: URL: https://github.com/apache/iceberg-cpp/pull/64#discussion_r2036418337 ## src/iceberg/transform.cc: ## @@ -72,4 +72,13 @@ expected IdentityTransformFunction::Transform( .message = "IdentityTransformFunction:

Re: [PR] feat: sort field/order json serialize/deserialization [iceberg-cpp]

2025-04-09 Thread via GitHub
wgtmac commented on code in PR #64: URL: https://github.com/apache/iceberg-cpp/pull/64#discussion_r2036565870 ## src/iceberg/json_internal.cc: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-09 Thread via GitHub
lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2036585617 ## src/iceberg/transform.cc: ## @@ -21,55 +21,26 @@ #include -namespace iceberg { +#include "iceberg/type.h" -namespace { -/// \brief Get the relative transfor

Re: [PR] SPARK: Remove dependency on hadoop's filesystem class from remove orphan files [iceberg]

2025-04-09 Thread via GitHub
liziyan-lzy commented on code in PR #12254: URL: https://github.com/apache/iceberg/pull/12254#discussion_r2036573158 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java: ## @@ -335,7 +344,39 @@ private Dataset listedFileDS() {

Re: [PR] feat: sort field/order json serialize/deserialization [iceberg-cpp]

2025-04-09 Thread via GitHub
gty404 commented on code in PR #64: URL: https://github.com/apache/iceberg-cpp/pull/64#discussion_r2036565518 ## src/iceberg/json_internal.cc: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: sort field/order json serialize/deserialization [iceberg-cpp]

2025-04-09 Thread via GitHub
wgtmac commented on code in PR #64: URL: https://github.com/apache/iceberg-cpp/pull/64#discussion_r2036522299 ## src/iceberg/sort_field.h: ## @@ -41,13 +43,52 @@ enum class SortDirection { /// Descending kDescending, }; +/// \brief Get the relative sort direction name +IC

Re: [PR] feat: add json serialization for schema [iceberg-cpp]

2025-04-09 Thread via GitHub
zhjwpku commented on code in PR #65: URL: https://github.com/apache/iceberg-cpp/pull/65#discussion_r2036560556 ## src/iceberg/util/macro_internal.h: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] feat: add json serialization for schema [iceberg-cpp]

2025-04-09 Thread via GitHub
wgtmac commented on PR #65: URL: https://github.com/apache/iceberg-cpp/pull/65#issuecomment-2791580017 Thanks @gty404 for the review! @lidavidm @zhjwpku @yingcai-cy Could you help review this? -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] feat: sort field/order json serialize/deserialization [iceberg-cpp]

2025-04-09 Thread via GitHub
zhjwpku commented on code in PR #64: URL: https://github.com/apache/iceberg-cpp/pull/64#discussion_r2036541375 ## src/iceberg/json_internal.cc: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-09 Thread via GitHub
zhjwpku commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2036495200 ## src/iceberg/transform.cc: ## @@ -21,55 +21,26 @@ #include -namespace iceberg { +#include "iceberg/type.h" -namespace { -/// \brief Get the relative transform

Re: [PR] feat: add json serialization for schema [iceberg-cpp]

2025-04-09 Thread via GitHub
wgtmac commented on code in PR #65: URL: https://github.com/apache/iceberg-cpp/pull/65#discussion_r2036491127 ## src/iceberg/schema_internal.cc: ## @@ -344,13 +382,254 @@ expected, Error> FromArrowSchema(const ArrowSchema& sche .message = "Arrow schema must be a struc

Re: [PR] feat: add json serialization for schema [iceberg-cpp]

2025-04-09 Thread via GitHub
gty404 commented on code in PR #65: URL: https://github.com/apache/iceberg-cpp/pull/65#discussion_r2036474805 ## src/iceberg/schema_internal.cc: ## @@ -344,13 +382,254 @@ expected, Error> FromArrowSchema(const ArrowSchema& sche .message = "Arrow schema must be a struc

Re: [PR] Flink: supports clean orphan files [iceberg]

2025-04-09 Thread via GitHub
sunxiaojian commented on PR #12754: URL: https://github.com/apache/iceberg/pull/12754#issuecomment-2791498219 @pvary @mxm Could you please review it? thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] Kafka Connect: Add dead letter queue support [iceberg]

2025-04-09 Thread via GitHub
kumarpritam863 commented on issue #10840: URL: https://github.com/apache/iceberg/issues/10840#issuecomment-2791453778 Hi @bryanck I am working on something similar, would you mind if I can take this up. Thanks. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Feat: support aliyun oss backend. [iceberg-go]

2025-04-09 Thread via GitHub
divinerapier closed pull request #216: Feat: support aliyun oss backend. URL: https://github.com/apache/iceberg-go/pull/216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[I] Integration test with Aliyun OSS [iceberg-rust]

2025-04-09 Thread via GitHub
divinerapier opened a new issue, #1188: URL: https://github.com/apache/iceberg-rust/issues/1188 ### Is your feature request related to a problem or challenge? I've submitted a pr(#1153) to add support for using Aliyun OSS as a backend storage. Since Aliyun OSS lacks open-source alter

Re: [PR] feat(io): add OSS storage implementation [iceberg-rust]

2025-04-09 Thread via GitHub
Xuanwo commented on PR #1153: URL: https://github.com/apache/iceberg-rust/pull/1153#issuecomment-2791396717 > I previously contacted Aliyun (OSS) pre-sales support to inquire about dedicated testing environments, but unfortunately, they currently do not offer such programs for open-source p

Re: [PR] feat(io): add OSS storage implementation [iceberg-rust]

2025-04-09 Thread via GitHub
Xuanwo merged PR #1153: URL: https://github.com/apache/iceberg-rust/pull/1153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Added `FsspecFileIO` method for OSS, virtual hosted style default to true, standardized key configurations for OSS [iceberg-python]

2025-04-09 Thread via GitHub
helmiazizm closed pull request #1788: Added `FsspecFileIO` method for OSS, virtual hosted style default to true, standardized key configurations for OSS URL: https://github.com/apache/iceberg-python/pull/1788 -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] AWS: Fix DynamoDB and Glue integration test failures [iceberg]

2025-04-09 Thread via GitHub
lliangyu-lin commented on code in PR #12718: URL: https://github.com/apache/iceberg/pull/12718#discussion_r2032183554 ## aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java: ## @@ -343,28 +342,32 @@ public void testRenameTableFailsToCreateNewTable() {

Re: [I] Support build full-text and vector index for iceberg [iceberg]

2025-04-09 Thread via GitHub
zhousun commented on issue #12636: URL: https://github.com/apache/iceberg/issues/12636#issuecomment-2791292531 Would love to collaborate on introducing index to iceberg (since we are also working on something similar). In my opinion, main concern for the proposal is 1. The strict

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-09 Thread via GitHub
lidavidm commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2036336978 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] Spark-3.5: Add unit tests for ColumnarBatchUtil [iceberg]

2025-04-09 Thread via GitHub
github-actions[bot] commented on PR #12275: URL: https://github.com/apache/iceberg/pull/12275#issuecomment-2791243060 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Spark-3.5: Add unit tests for ColumnarBatchUtil [iceberg]

2025-04-09 Thread via GitHub
github-actions[bot] closed pull request #12275: Spark-3.5: Add unit tests for ColumnarBatchUtil URL: https://github.com/apache/iceberg/pull/12275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Core: Support first-row-id for manifests and manifest lists [iceberg]

2025-04-09 Thread via GitHub
rdblue commented on code in PR #12672: URL: https://github.com/apache/iceberg/pull/12672#discussion_r2036175237 ## core/src/main/java/org/apache/iceberg/V3Metadata.java: ## @@ -140,6 +143,22 @@ private Object get(int pos) { return wrapped.partitions(); case 1

[PR] Doc: Make next-row-id required in v3 [iceberg]

2025-04-09 Thread via GitHub
ebyhr opened a new pull request, #12757: URL: https://github.com/apache/iceberg/pull/12757 #12593 made `next-row-id` field required in my understanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Core: Use InputFile.location() Instead of Direct Object Reference in Error Messages [iceberg]

2025-04-09 Thread via GitHub
Jordano-Dremio commented on PR #12716: URL: https://github.com/apache/iceberg/pull/12716#issuecomment-2791211643 @nastra , as mentioned on the OutputFile PR (https://github.com/apache/iceberg/pull/12755) It appeared that my local was disconnected from my remote iceberg repository. Everythin

Re: [PR] Core: Use OutputFile.location() Instead of Direct Object Reference in Error Messages [iceberg]

2025-04-09 Thread via GitHub
Jordano-Dremio commented on code in PR #12755: URL: https://github.com/apache/iceberg/pull/12755#discussion_r2036284750 ## core/src/main/java/org/apache/iceberg/ManifestWriter.java: ## @@ -246,7 +246,7 @@ protected FileAppender> newAppender( .overwrite()

Re: [PR] Core: Use OutputFile.location() Instead of Direct Object Reference in Error Messages [iceberg]

2025-04-09 Thread via GitHub
Jordano-Dremio commented on code in PR #12755: URL: https://github.com/apache/iceberg/pull/12755#discussion_r2036285005 ## core/src/main/java/org/apache/iceberg/ManifestListWriter.java: ## @@ -136,7 +136,7 @@ protected FileAppender newAppender(OutputFile file, Map

[PR] feat (catalog/rest): Add create view integration test [iceberg-go]

2025-04-09 Thread via GitHub
dttung2905 opened a new pull request, #387: URL: https://github.com/apache/iceberg-go/pull/387 As mentioned in the previous comment https://github.com/apache/iceberg-go/pull/376#pullrequestreview-2747444932 I managed to create a test bash script to run the integration test successful

[PR] Core: Make converting external avro record schema to iceberg schema startin… [iceberg]

2025-04-09 Thread via GitHub
rzhang10 opened a new pull request, #12756: URL: https://github.com/apache/iceberg/pull/12756 …g field id at 1 When converting an external Avro schema (which doesn't have field_id property in the avro metadata) to an Iceberg schema, the external avro record schema should start assign

Re: [I] Create Iceberg Table from pyarrow Schema with no IDs [iceberg-python]

2025-04-09 Thread via GitHub
Fokko commented on issue #278: URL: https://github.com/apache/iceberg-python/issues/278#issuecomment-2791154801 @0x26res Thanks for reaching out here. All clients re-assign the IDs to make sure that they are unique. The idea is that users don't have to worry about setting the IDs. This has

Re: [PR] Spark 3.5 row lineage [iceberg]

2025-04-09 Thread via GitHub
nastra commented on code in PR #12736: URL: https://github.com/apache/iceberg/pull/12736#discussion_r2036234436 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRowLineagePropogation.java: ## @@ -0,0 +1,489 @@ +/* + * Licensed to the Apache So

Re: [PR] Spark 3.5 row lineage [iceberg]

2025-04-09 Thread via GitHub
nastra commented on code in PR #12736: URL: https://github.com/apache/iceberg/pull/12736#discussion_r2036232707 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java: ## @@ -327,7 +327,11 @@ public void pruneColumns(StructType requestedSchema) {

Re: [I] Glue scan with filter throws list index out of range [iceberg-python]

2025-04-09 Thread via GitHub
Fokko closed issue #1804: Glue scan with filter throws list index out of range URL: https://github.com/apache/iceberg-python/issues/1804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Glue scan with filter throws list index out of range [iceberg-python]

2025-04-09 Thread via GitHub
Fokko closed issue #1804: Glue scan with filter throws list index out of range URL: https://github.com/apache/iceberg-python/issues/1804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Temporary fix for Arrow issue 46057 [iceberg-python]

2025-04-09 Thread via GitHub
Fokko commented on PR #1901: URL: https://github.com/apache/iceberg-python/pull/1901#issuecomment-2791129726 Thanks @koenvo for fixing this 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Temporary fix for Arrow issue 46057 [iceberg-python]

2025-04-09 Thread via GitHub
Fokko commented on code in PR #1901: URL: https://github.com/apache/iceberg-python/pull/1901#discussion_r2036227747 ## pyiceberg/io/pyarrow.py: ## @@ -1441,11 +1441,15 @@ def _task_to_record_batches( # Apply the user filter if pyarrow_filter is not No

Re: [PR] Temporary fix for Arrow issue 46057 [iceberg-python]

2025-04-09 Thread via GitHub
Fokko merged PR #1901: URL: https://github.com/apache/iceberg-python/pull/1901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [I] Patch release request CVE-2025-30065 [iceberg]

2025-04-09 Thread via GitHub
ajantha-bhat commented on issue #12749: URL: https://github.com/apache/iceberg/issues/12749#issuecomment-2791121992 1.9.0 RC0 is out for voting. Which has a fix for this CVE https://lists.apache.org/thread/fvm5dg2kd7ofm7x2xo3oyjjl9r8dcssq -- This is an automated message from the Apache

Re: [I] Manifest List/Entry Creation [iceberg-go]

2025-04-09 Thread via GitHub
zeroshade closed issue #172: Manifest List/Entry Creation URL: https://github.com/apache/iceberg-go/issues/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Throw on `{write.folder-storage.path,write.object-storage.path}` properties [iceberg]

2025-04-09 Thread via GitHub
Fokko merged PR #12315: URL: https://github.com/apache/iceberg/pull/12315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

[PR] test-container recipe for iceberg [iceberg-go]

2025-04-09 Thread via GitHub
laskoviymishka opened a new pull request, #388: URL: https://github.com/apache/iceberg-go/pull/388 add a small helper that start docker compose inside a test, to simplify local dev-flow a bit. there is still a check that will skip docker compose setup if there is already presented required

Re: [PR] Core: Use OutputFile.location() Instead of Direct Object Reference in Error Messages [iceberg]

2025-04-09 Thread via GitHub
Jordano-Dremio commented on code in PR #12755: URL: https://github.com/apache/iceberg/pull/12755#discussion_r2036203729 ## core/src/main/java/org/apache/iceberg/ManifestListWriter.java: ## @@ -136,7 +136,7 @@ protected FileAppender newAppender(OutputFile file, Map

Re: [PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-09 Thread via GitHub
Fokko commented on PR #1887: URL: https://github.com/apache/iceberg-python/pull/1887#issuecomment-2791104936 Hey @arnaudbriche OSX should work fine (using it myself). We vendor the `hive_metastore` modules, so I'm not sure what's going on there. Which Python version are you using? Do you ha

Re: [PR] Core: Use OutputFile.location() Instead of Direct Object Reference in Error Messages [iceberg]

2025-04-09 Thread via GitHub
Jordano-Dremio commented on code in PR #12755: URL: https://github.com/apache/iceberg/pull/12755#discussion_r2036203729 ## core/src/main/java/org/apache/iceberg/ManifestListWriter.java: ## @@ -136,7 +136,7 @@ protected FileAppender newAppender(OutputFile file, Map

Re: [PR] Core: Support first-row-id for manifests and manifest lists [iceberg]

2025-04-09 Thread via GitHub
rdblue commented on code in PR #12672: URL: https://github.com/apache/iceberg/pull/12672#discussion_r2036194341 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java: ## @@ -138,8 +137,8 @@ public void roundTripSerdeV1() { } @Parameteri

Re: [PR] Core: Support first-row-id for manifests and manifest lists [iceberg]

2025-04-09 Thread via GitHub
rdblue commented on code in PR #12672: URL: https://github.com/apache/iceberg/pull/12672#discussion_r2036192418 ## core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java: ## @@ -213,27 +224,125 @@ public void testV2ManifestRewriteWithInheritance() throws IOExcept

[PR] Refactor `Metadata` in `Transaction` [iceberg-python]

2025-04-09 Thread via GitHub
Fokko opened a new pull request, #1903: URL: https://github.com/apache/iceberg-python/pull/1903 # Rationale for this change Today, we have a copy of the `TableMetadata` on the `Table` and the `Transaction`. This PR changes that logic to re-use the one on the table, and add the change

Re: [PR] Core: Support first-row-id for manifests and manifest lists [iceberg]

2025-04-09 Thread via GitHub
rdblue commented on code in PR #12672: URL: https://github.com/apache/iceberg/pull/12672#discussion_r2036185496 ## core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java: ## @@ -213,27 +224,125 @@ public void testV2ManifestRewriteWithInheritance() throws IOExcept

Re: [PR] Core: Support first-row-id for manifests and manifest lists [iceberg]

2025-04-09 Thread via GitHub
rdblue commented on code in PR #12672: URL: https://github.com/apache/iceberg/pull/12672#discussion_r2036177256 ## core/src/test/java/org/apache/iceberg/TestManifestListVersions.java: ## @@ -150,25 +163,140 @@ public void testV2Write() throws IOException { assertThat(manife

Re: [PR] Core: Support first-row-id for manifests and manifest lists [iceberg]

2025-04-09 Thread via GitHub
rdblue commented on code in PR #12672: URL: https://github.com/apache/iceberg/pull/12672#discussion_r2036184794 ## core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java: ## @@ -152,9 +160,10 @@ public void testV2WriteWithInheritance() throws IOException { c

Re: [D] Glue catalog updating [iceberg-rust]

2025-04-09 Thread via GitHub
GitHub user hugokitano added a comment to the discussion: Glue catalog updating Is there no workaround at the moment? Seems like writing is therefore just not functional GitHub link: https://github.com/apache/iceberg-rust/discussions/1168#discussioncomment-12753788 This is an automatica

[PR] Core: Use OutputFile.location() Instead of Direct Object Reference in Error Messages [iceberg]

2025-04-09 Thread via GitHub
Jordano-Dremio opened a new pull request, #12755: URL: https://github.com/apache/iceberg/pull/12755 Object Instances of the OutputFile Interface are occasionally referenced directly in error messages. [Example](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceber

Re: [PR] Core: Use OutputFile.location() Instead of Direct Object Reference in Error Messages [iceberg]

2025-04-09 Thread via GitHub
nastra commented on code in PR #12755: URL: https://github.com/apache/iceberg/pull/12755#discussion_r2036163235 ## core/src/main/java/org/apache/iceberg/ManifestListWriter.java: ## @@ -136,7 +136,7 @@ protected FileAppender newAppender(OutputFile file, Map

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
nastra merged PR #12595: URL: https://github.com/apache/iceberg/pull/12595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] feat: add apply in transaction to support stack action [iceberg-rust]

2025-04-09 Thread via GitHub
jonathanc-n commented on PR #949: URL: https://github.com/apache/iceberg-rust/pull/949#issuecomment-2791012883 I think we should try to move this along. cc @liurenjie1024 @Fokko @sdd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[PR] Fix for metadata entries table for MOR tables containing Delete Files. [iceberg-python]

2025-04-09 Thread via GitHub
guptaakashdeep opened a new pull request, #1902: URL: https://github.com/apache/iceberg-python/pull/1902 Closes #1884 # Rationale for this change table.inspect.entries() fails when table is MOR table and has Delete Files present in it. Iceberg MOR Table is created via

Re: [PR] Fix for metadata entries table for MOR tables containing Delete Files. [iceberg-python]

2025-04-09 Thread via GitHub
guptaakashdeep commented on PR #1902: URL: https://github.com/apache/iceberg-python/pull/1902#issuecomment-2790860835 This fixes #1884 @kevinjqliu Can this fix be reviewed once? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
nastra commented on code in PR #12595: URL: https://github.com/apache/iceberg/pull/12595#discussion_r2035764888 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -194,7 +209,9 @@ protected RESTCatalog initCatalog(String catalogName, Map additi

Re: [I] Patch release request CVE-2025-30065 [iceberg]

2025-04-09 Thread via GitHub
ajantha-bhat commented on issue #12749: URL: https://github.com/apache/iceberg/issues/12749#issuecomment-2790921731 We are planning for 1.9.0 RC today. So, new version of Iceberg will be out with this CVE fix. Regarding patch release. Are you looking for 1.8.x or 1.7.x? But this CVE

Re: [PR] feat: add table metadata definition [iceberg-cpp]

2025-04-09 Thread via GitHub
Fokko commented on PR #62: URL: https://github.com/apache/iceberg-cpp/pull/62#issuecomment-2786987329 Thanks @wgtmac for working on this, and thanks @zhjwpku for the review 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Support adding parquet files to partitioned table [iceberg-rust]

2025-04-09 Thread via GitHub
liurenjie1024 commented on issue #1035: URL: https://github.com/apache/iceberg-rust/issues/1035#issuecomment-2789512048 cc @jonathanc-n Do you think it's better to move it to 0.6.0 milestone? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Patch release request CVE-2025-30065 [iceberg]

2025-04-09 Thread via GitHub
kgduong commented on issue #12749: URL: https://github.com/apache/iceberg/issues/12749#issuecomment-2790894134 +1 are we able to patch release this to older versions of Iceberg? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
ajantha-bhat closed pull request #12595: CORE: Allow HTTPClient to parse headers from properties. URL: https://github.com/apache/iceberg/pull/12595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
wolflex888 commented on code in PR #12595: URL: https://github.com/apache/iceberg/pull/12595#discussion_r2036069072 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -332,6 +349,26 @@ public void testInitializeWithBadArguments() throws IOException {

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
wolflex888 commented on code in PR #12595: URL: https://github.com/apache/iceberg/pull/12595#discussion_r2036069072 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -332,6 +349,26 @@ public void testInitializeWithBadArguments() throws IOException {

Re: [I] Add support to FileIO for Azure and GCS [iceberg-go]

2025-04-09 Thread via GitHub
zeroshade commented on issue #65: URL: https://github.com/apache/iceberg-go/issues/65#issuecomment-2790865322 This has been implemented! Thanks everyone! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
ajantha-bhat commented on code in PR #12595: URL: https://github.com/apache/iceberg/pull/12595#discussion_r2036062862 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -121,9 +122,19 @@ public void createCatalog() throws Exception { ImmutableMap.

Re: [I] Add support to FileIO for Azure and GCS [iceberg-go]

2025-04-09 Thread via GitHub
zeroshade closed issue #65: Add support to FileIO for Azure and GCS URL: https://github.com/apache/iceberg-go/issues/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
ajantha-bhat commented on PR #12595: URL: https://github.com/apache/iceberg/pull/12595#issuecomment-2790858710 Anything functional remaining for this PR? If not we can merge it and handle the refactoring ourself as we are waiting for the release. -- This is an automated message from the

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
ajantha-bhat commented on PR #12595: URL: https://github.com/apache/iceberg/pull/12595#issuecomment-2790854616 closing and re-opening PR as Spark test failed due to flakiness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
ajantha-bhat commented on code in PR #12595: URL: https://github.com/apache/iceberg/pull/12595#discussion_r2036060610 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -121,9 +122,19 @@ public void createCatalog() throws Exception { ImmutableMap.

Re: [PR] Core,Api: Add overwrite option when register external table to catalog [iceberg]

2025-04-09 Thread via GitHub
guykhazma commented on code in PR #12228: URL: https://github.com/apache/iceberg/pull/12228#discussion_r2036041469 ## core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java: ## @@ -71,23 +70,35 @@ public Table loadTable(TableIdentifier identifier) { } @Override

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
nastra commented on code in PR #12595: URL: https://github.com/apache/iceberg/pull/12595#discussion_r2036052912 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -121,9 +122,19 @@ public void createCatalog() throws Exception { ImmutableMap.of(Cat

Re: [PR] Core,Api: Add overwrite option when register external table to catalog [iceberg]

2025-04-09 Thread via GitHub
guykhazma commented on code in PR #12228: URL: https://github.com/apache/iceberg/pull/12228#discussion_r2036041469 ## core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java: ## @@ -71,23 +70,35 @@ public Table loadTable(TableIdentifier identifier) { } @Override

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-09 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2035537020 ## src/iceberg/snapshot_ref.h: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
adutra commented on code in PR #12595: URL: https://github.com/apache/iceberg/pull/12595#discussion_r2035988748 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -121,9 +122,19 @@ public void createCatalog() throws Exception { ImmutableMap.of(Cat

Re: [I] Kafka Connect: Add delta writer support [iceberg]

2025-04-09 Thread via GitHub
gdanielli commented on issue #10842: URL: https://github.com/apache/iceberg/issues/10842#issuecomment-2790733351 Are you still considering the possibility of implementing this feature in future versions? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-09 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2035537509 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [I] BaseDeleteLoader may ignore delete records for binary columns [iceberg]

2025-04-09 Thread via GitHub
pvary commented on issue #11239: URL: https://github.com/apache/iceberg/issues/11239#issuecomment-2790596194 @Ge: Would `TestTaskEqualityDeltaWriter` help you to reproduce the case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Alternative implementation for building and testing hive-metastore with Hive 3 and Hive 4 [iceberg]

2025-04-09 Thread via GitHub
pvary commented on code in PR #12721: URL: https://github.com/apache/iceberg/pull/12721#discussion_r2035550694 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -104,12 +103,12 @@ public void initialize(String inputName, Map properties) { }

Re: [I] Support for writing Parquet files from the Iceberg Java API without the Hadoop Configuration class [iceberg]

2025-04-09 Thread via GitHub
ms commented on issue #10180: URL: https://github.com/apache/iceberg/issues/10180#issuecomment-2790585440 It's possible to use Flink with Iceberg with two Hadoop jars only, hadoop-common and hadoop-mapreduce-client-core, and exclude all their transitive dependencies. The Parquet read/wr

[PR] doc: `add_parquet_files` is not fully supported for version 0.5.0 [iceberg-rust]

2025-04-09 Thread via GitHub
jonathanc-n opened a new pull request, #1187: URL: https://github.com/apache/iceberg-rust/pull/1187 ## Which issue does this PR close? - Mentioned in #1035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] Unable to use GlueCatalog in flink environments without hadoop [iceberg]

2025-04-09 Thread via GitHub
vbabenkoru commented on issue #3044: URL: https://github.com/apache/iceberg/issues/3044#issuecomment-2790572579 For anyone using Scala/SBT, here is what worked for me: ``` assembly / assemblyShadeRules := Seq( ShadeRule.rename("org.apache.hadoop.**" -> "shadow.org.apache.hadoo

[PR] Fix concurrency bug in REST catalog request signing [iceberg-go]

2025-04-09 Thread via GitHub
jhump opened a new pull request, #384: URL: https://github.com/apache/iceberg-go/pull/384 A hasher is not thread-safe, yet the same hasher was being used for all requests. If applications made concurrent calls to the same REST catalog implementation, they could end up writing to the same ha

Re: [I] Flink: Decouple the iceberg integration work from hadoop libraries [iceberg]

2025-04-09 Thread via GitHub
vbabenkoru commented on issue #3117: URL: https://github.com/apache/iceberg/issues/3117#issuecomment-2790536359 I just hit this issue when trying to create a basic Flink app with an Iceberg catalog, and there is no straightforward workaround, apparently. The repro is very easy: run Flink do

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
wolflex888 commented on code in PR #12595: URL: https://github.com/apache/iceberg/pull/12595#discussion_r2035839334 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -121,9 +122,19 @@ public void createCatalog() throws Exception { ImmutableMap.of

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
nastra commented on code in PR #12595: URL: https://github.com/apache/iceberg/pull/12595#discussion_r2035847056 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -121,9 +122,19 @@ public void createCatalog() throws Exception { ImmutableMap.of(Cat

Re: [PR] Flink 1.19: Run without Hadoop [iceberg]

2025-04-09 Thread via GitHub
vbabenkoru commented on PR #7369: URL: https://github.com/apache/iceberg/pull/7369#issuecomment-2790465074 Same, for some reason Flink requires Hadoop and yet does not come with it? We're using the Kubernetes Operator and would like to avoid customizing the image to fix this bug. -- This

Re: [PR] Core: Drop invalid function comment for HTTPClient.isSuccessful [iceberg]

2025-04-09 Thread via GitHub
nastra merged PR #12742: URL: https://github.com/apache/iceberg/pull/12742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

[I] Provide access to a manifest's schema and partition spec [iceberg-go]

2025-04-09 Thread via GitHub
jhump opened a new issue, #386: URL: https://github.com/apache/iceberg-go/issues/386 ### Feature Request / Improvement Currently, manifest Avro files store the corresponding Iceberg schema and schema ID as well as partition spec and partition spec ID in the files' metadata. But there

Re: [I] Create Iceberg Table from pyarrow Schema with no IDs [iceberg-python]

2025-04-09 Thread via GitHub
0x26res commented on issue #278: URL: https://github.com/apache/iceberg-python/issues/278#issuecomment-2790415821 Sorry I'm not sure if this is the right place to ask this question. My understanding from this conversation is that when a user provides a `pa.Schema` to create an iceberg

[PR] Flink: Flink supports clean orphan files [iceberg]

2025-04-09 Thread via GitHub
sunxiaojian opened a new pull request, #12754: URL: https://github.com/apache/iceberg/pull/12754 closed : https://github.com/apache/iceberg/issues/12674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] CORE: Allow HTTPClient to parse headers from properties. [iceberg]

2025-04-09 Thread via GitHub
nastra commented on code in PR #12595: URL: https://github.com/apache/iceberg/pull/12595#discussion_r2035761879 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -121,9 +122,19 @@ public void createCatalog() throws Exception { ImmutableMap.of(Cat

Re: [PR] feat: support S3 Table Buckets with S3TablesCatalog [iceberg-python]

2025-04-09 Thread via GitHub
felixscherz commented on PR #1429: URL: https://github.com/apache/iceberg-python/pull/1429#issuecomment-2790280420 Yes! You use the Rest catalog and should be able to follow this guide: https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-tables-integrating-open-source.html. I haven't

  1   2   >