wgtmac commented on code in PR #64:
URL: https://github.com/apache/iceberg-cpp/pull/64#discussion_r2036522299
##########
src/iceberg/sort_field.h:
##########
@@ -41,13 +43,52 @@ enum class SortDirection {
/// Descending
kDescending,
};
+/// \brief Get the relative sort direction name
+ICEBERG_EXPORT constexpr std::string_view SortDirectionToString(SortDirection
direction) {
Review Comment:
nit: we should probably only declare these functions here and put all
implementation in the .cc file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
