rzhang10 opened a new pull request, #12756:
URL: https://github.com/apache/iceberg/pull/12756

   …g field id at 1
   
   When converting an external Avro schema (which doesn't have field_id 
property in the avro metadata) to an Iceberg schema, the external avro record 
schema should start assign ID at 1, not 0, by the Iceberg convention. This PR 
fixes that.
   Also, as part of this, cleaned `SchemaToType` constructor since it doesn't 
need to take in the `root` schema itself.
   
   Added a unit test `testExternalAvroRecordSchema` to verify the behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to