wgtmac commented on code in PR #65:
URL: https://github.com/apache/iceberg-cpp/pull/65#discussion_r2036491127
##########
src/iceberg/schema_internal.cc:
##########
@@ -344,13 +382,254 @@ expected<std::unique_ptr<Schema>, Error>
FromArrowSchema(const ArrowSchema& sche
.message = "Arrow schema must be a struct type for Iceberg schema"}};
}
- auto* struct_type = static_cast<StructType*>(type.get());
+ auto& struct_type = static_cast<StructType&>(*type);
+ return FromStructType(std::move(struct_type), schema_id);
+}
+
+nlohmann::json FieldToJson(const SchemaField& field) {
+ nlohmann::json json;
+ json[kId] = field.field_id();
+ json[kName] = field.name();
+ json[kRequired] = !field.optional();
+ json[kType] = TypeToJson(*field.type());
+ return json;
+}
+
+nlohmann::json TypeToJson(const Type& type) {
+ switch (type.type_id()) {
+ case TypeId::kStruct: {
+ const auto& struct_type = static_cast<const StructType&>(type);
+ nlohmann::json json;
+ json[kType] = kStruct;
+ nlohmann::json fields_json = nlohmann::json::array();
+ for (const auto& field : struct_type.fields()) {
+ fields_json.push_back(FieldToJson(field));
+ // TODO(gangwu): add default values
+ }
+ json[kFields] = fields_json;
+ return json;
+ }
+ case TypeId::kList: {
+ const auto& list_type = static_cast<const ListType&>(type);
+ nlohmann::json json;
+ json[kType] = kList;
+
+ const auto& element_field = list_type.fields().front();
Review Comment:
This is guaranteed by `ListType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
