Re: [PR] Spark: Test metadata tables with format-version=3 [iceberg]

2025-01-30 Thread via GitHub
nastra commented on code in PR #12135: URL: https://github.com/apache/iceberg/pull/12135#discussion_r1936775702 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java: ## @@ -62,6 +67,44 @@ @ExtendWith(ParameterizedTestExtensi

Re: [PR] Kafka Connect: Add kerberos authentication option [iceberg]

2025-01-30 Thread via GitHub
Dawnpool commented on PR #12119: URL: https://github.com/apache/iceberg/pull/12119#issuecomment-2626454244 @bryanck I believe what I'm referring to is related to the Iceberg Flink sink, which uses Kerberos-authenticated HDFS as its FileIO. I'm actually using Flink with Kerberos-authen

Re: [PR] Spark: Support singular form of years, months, days, and hours functions [iceberg]

2025-01-30 Thread via GitHub
wypoon commented on code in PR #12117: URL: https://github.com/apache/iceberg/pull/12117#discussion_r1936720348 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/functions/SparkFunctions.java: ## @@ -29,24 +29,41 @@ public class SparkFunctions { private SparkFuncti

Re: [PR] Data: Add partition stats writer and reader [iceberg]

2025-01-30 Thread via GitHub
ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1777915925 ## core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java: ## @@ -370,17 +371,17 @@ public void testPartitionStatsWithSchemaEvolution() throws Except

Re: [PR] Data: Add partition stats writer and reader [iceberg]

2025-01-30 Thread via GitHub
ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1777912510 ## core/src/main/java/org/apache/iceberg/PartitionStats.java: ## @@ -249,4 +250,45 @@ public void set(int pos, T value) { throw new UnsupportedOperatio

Re: [PR] chore(deps): Bump arrow-cast from 53.3.0 to 53.4.0 [iceberg-rust]

2025-01-30 Thread via GitHub
Fokko merged PR #925: URL: https://github.com/apache/iceberg-rust/pull/925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Spark: Support singular form of years, months, days, and hours functions [iceberg]

2025-01-30 Thread via GitHub
wypoon commented on code in PR #12117: URL: https://github.com/apache/iceberg/pull/12117#discussion_r1936720348 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/functions/SparkFunctions.java: ## @@ -29,24 +29,41 @@ public class SparkFunctions { private SparkFuncti

Re: [I] There is a bug with the new version of boto used by s3fs that prevents writes to non-AWS S3 buckets [iceberg-python]

2025-01-30 Thread via GitHub
maarek commented on issue #1546: URL: https://github.com/apache/iceberg-python/issues/1546#issuecomment-2626305180 This occurs for me as well against an OCI Object Storage using S3 compat api. With Boto3 request I can set the config to the necessary config to disable the checksum validatio

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

2025-01-30 Thread via GitHub
tusharchou commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1936663741 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1731,214 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field

Re: [PR] Add ResidualVisitor to compute residuals [iceberg-python]

2025-01-30 Thread via GitHub
tusharchou commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1936663741 ## pyiceberg/expressions/visitors.py: ## @@ -1731,3 +1731,214 @@ def _can_contain_nulls(self, field_id: int) -> bool: def _can_contain_nans(self, field

Re: [PR] Parquet: Fix Reader leak by removing useless copy [iceberg]

2025-01-30 Thread via GitHub
zizon commented on code in PR #12079: URL: https://github.com/apache/iceberg/pull/12079#discussion_r1936633094 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java: ## @@ -82,22 +75,10 @@ static OutputFile file(org.apache.iceberg.io.OutputFile file, Configuration

Re: [PR] Spark: Support singular form of years, months, days, and hours functions [iceberg]

2025-01-30 Thread via GitHub
wypoon commented on PR #12117: URL: https://github.com/apache/iceberg/pull/12117#issuecomment-2626205994 @ebyhr thank you for your reviews. @szehon-ho @amogh-jahagirdar would you mind taking a look? It would be nice to get this into 1.8.0. -- This is an automated message from the Apach

Re: [PR] Spark: Support singular form of years, months, days, and hours functions [iceberg]

2025-01-30 Thread via GitHub
wypoon commented on code in PR #12117: URL: https://github.com/apache/iceberg/pull/12117#discussion_r1936326700 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSparkDaysFunction.java: ## @@ -39,6 +39,9 @@ public void testDates() { assertThat(scalarSql("SE

Re: [I] Hivemetastore unable to create hive lock after upgrading from hivemetastore 3.1.3 to 4.0.0 during iceberg operations [iceberg]

2025-01-30 Thread via GitHub
kosmldev commented on issue #11784: URL: https://github.com/apache/iceberg/issues/11784#issuecomment-2626164330 Another solution - add this to hms config ``` hive.support.concurrency true hive.txn.manager org.apache.hadoop.hive.ql.lockmgr.DbTxnManage

Re: [PR] Variants: Implement toString [iceberg]

2025-01-30 Thread via GitHub
amogh-jahagirdar commented on code in PR #12138: URL: https://github.com/apache/iceberg/pull/12138#discussion_r1936558290 ## core/src/main/java/org/apache/iceberg/variants/VariantMetadata.java: ## @@ -34,4 +34,20 @@ public interface VariantMetadata extends Variants.Serialized {

Re: [I] MERGE INTO TABLE is not supported temporarily [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #5424: URL: https://github.com/apache/iceberg/issues/5424#issuecomment-2625997702 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1936493915 ## parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java: ## @@ -54,101 +57,108 @@ public static T visit( } else { // if not a primi

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1936493090 ## parquet/src/main/java/org/apache/iceberg/parquet/PruneColumns.java: ## @@ -162,9 +168,11 @@ private Integer getId(Type type) { return type.getId() == null ? nu

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1936492645 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantVisitor.java: ## @@ -0,0 +1,287 @@ +/* + * + * * Licensed to the Apache Software Foundation (ASF) un

Re: [I] Spark: Support alter partition in V2 Catalog SparkCatalog Class [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #3558: Spark: Support alter partition in V2 Catalog SparkCatalog Class URL: https://github.com/apache/iceberg/issues/3558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] Encryption via RewriteFiles [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #3928: Encryption via RewriteFiles URL: https://github.com/apache/iceberg/issues/3928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] Avro referenced in metadata json file is missing [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #7137: URL: https://github.com/apache/iceberg/issues/7137#issuecomment-2625997753 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [PR] Parquet: Correctly prune nested columns [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on PR #11373: URL: https://github.com/apache/iceberg/pull/11373#issuecomment-2625998153 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [I] Can not parse sort order when there are more than one sql extensions specified and iceberg extension is not placed at the right most position [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #8004: URL: https://github.com/apache/iceberg/issues/8004#issuecomment-2625997887 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] An exception occurred while writing iceberg data through Spark: org. apache. iceberg. exceptions. CommitFailedException: metadata location has changed [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #9178: URL: https://github.com/apache/iceberg/issues/9178#issuecomment-2625997929 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [PR] Parquet: Correctly prune nested columns [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed pull request #11373: Parquet: Correctly prune nested columns URL: https://github.com/apache/iceberg/pull/11373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Flink: Make Hadoop an optional dependency [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #7332: URL: https://github.com/apache/iceberg/issues/7332#issuecomment-2625997789 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Spark: Support alter partition in V2 Catalog SparkCatalog Class [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #3558: URL: https://github.com/apache/iceberg/issues/3558#issuecomment-2625997657 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1936494392 ## parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java: ## @@ -217,11 +238,19 @@ public T map(Types.MapType iMap, GroupType map, T key, T valu

Re: [I] Partitions metadata table shows old partitions [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #6257: Partitions metadata table shows old partitions URL: https://github.com/apache/iceberg/issues/6257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1936493604 ## parquet/src/main/java/org/apache/iceberg/parquet/TypeToMessageType.java: ## @@ -117,6 +120,14 @@ public GroupType map(MapType map, Type.Repetition repetition, int

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1936491857 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetSchemaUtil.java: ## @@ -75,6 +76,32 @@ private static Schema convertInternal( converter.getAliases(

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1936491220 ## api/src/main/java/org/apache/iceberg/types/GetProjectedIds.java: ## @@ -47,7 +47,7 @@ public Set struct(Types.StructType struct, List> fieldResu @Override

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1936491473 ## core/src/main/java/org/apache/iceberg/variants/Variants.java: ## @@ -209,59 +213,59 @@ public static VariantPrimitive ofNull() { return new PrimitiveWrapper<>(

Re: [I] Why Iceberg do not support column with default value? [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #8527: Why Iceberg do not support column with default value? URL: https://github.com/apache/iceberg/issues/8527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] insert to hive table with icberg table format is failing [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #7840: URL: https://github.com/apache/iceberg/issues/7840#issuecomment-2625997825 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Concerns with `String.toLowerCase()` in default Locale [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #9276: URL: https://github.com/apache/iceberg/issues/9276#issuecomment-2625997952 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Why Iceberg do not support column with default value? [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #8527: URL: https://github.com/apache/iceberg/issues/8527#issuecomment-2625997904 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] An exception occurred while writing iceberg data through Spark: org. apache. iceberg. exceptions. CommitFailedException: metadata location has changed [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #9178: An exception occurred while writing iceberg data through Spark: org. apache. iceberg. exceptions. CommitFailedException: metadata location has changed URL: https://github.com/apache/iceberg/issues/9178 -- This is an automated message from the Apache Gi

Re: [I] spark v3.2 RoaringBitMap dependency is causing build failure [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #7909: spark v3.2 RoaringBitMap dependency is causing build failure URL: https://github.com/apache/iceberg/issues/7909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] Flink: Make Hadoop an optional dependency [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #7332: Flink: Make Hadoop an optional dependency URL: https://github.com/apache/iceberg/issues/7332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Core: Prevent dropping column which is referenced by active partition specs [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on PR #11842: URL: https://github.com/apache/iceberg/pull/11842#issuecomment-2625998224 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [I] spark v3.2 RoaringBitMap dependency is causing build failure [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #7909: URL: https://github.com/apache/iceberg/issues/7909#issuecomment-2625997858 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Partitions metadata table shows old partitions [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #6257: URL: https://github.com/apache/iceberg/issues/6257#issuecomment-2625997724 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Encryption via RewriteFiles [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #3928: URL: https://github.com/apache/iceberg/issues/3928#issuecomment-2625997678 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [PR] Core: Prevent dropping column which is referenced by active partition specs [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed pull request #11842: Core: Prevent dropping column which is referenced by active partition specs URL: https://github.com/apache/iceberg/pull/11842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Spark: Session level Iceberg table config defaults [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #2270: URL: https://github.com/apache/iceberg/issues/2270#issuecomment-2625997581 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] MERGE INTO TABLE is not supported temporarily [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #5424: MERGE INTO TABLE is not supported temporarily URL: https://github.com/apache/iceberg/issues/5424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Concerns with `String.toLowerCase()` in default Locale [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #9276: Concerns with `String.toLowerCase()` in default Locale URL: https://github.com/apache/iceberg/issues/9276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Can not parse sort order when there are more than one sql extensions specified and iceberg extension is not placed at the right most position [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #8004: Can not parse sort order when there are more than one sql extensions specified and iceberg extension is not placed at the right most position URL: https://github.com/apache/iceberg/issues/8004 -- This is an automated message from the Apache Git Service

Re: [I] insert to hive table with icberg table format is failing [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #7840: insert to hive table with icberg table format is failing URL: https://github.com/apache/iceberg/issues/7840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [I] Avro referenced in metadata json file is missing [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #7137: Avro referenced in metadata json file is missing URL: https://github.com/apache/iceberg/issues/7137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] Variants: Implement toString [iceberg]

2025-01-30 Thread via GitHub
rdblue opened a new pull request, #12138: URL: https://github.com/apache/iceberg/pull/12138 This implements `toString` for Variant classes, which is more friendly when reading parameterized test cases. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Spark: Session level Iceberg table config defaults [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #2270: Spark: Session level Iceberg table config defaults URL: https://github.com/apache/iceberg/issues/2270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] Spark: read migrate table error [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] commented on issue #2896: URL: https://github.com/apache/iceberg/issues/2896#issuecomment-2625997631 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Spark: read migrate table error [iceberg]

2025-01-30 Thread via GitHub
github-actions[bot] closed issue #2896: Spark: read migrate table error URL: https://github.com/apache/iceberg/issues/2896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936458957 ## spark/v3.5/spark-runtime/LICENSE: ## @@ -203,109 +203,78 @@ -This binary arti

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936456243 ## spark/v3.5/spark-runtime/LICENSE: ## @@ -203,109 +203,78 @@ -This binary arti

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
amogh-jahagirdar commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936454435 ## spark/v3.5/spark-runtime/NOTICE: ## @@ -497,12 +680,46 @@ file: -Th

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936448470 ## spark/v3.5/spark-runtime/NOTICE: ## @@ -82,42 +245,7 @@ NOTICE file: -This bi

[PR] BugFix: PartitionStatsUtil#computeStats returns incomplete stats in case of partition evolution [iceberg]

2025-01-30 Thread via GitHub
deniskuzZ opened a new pull request, #12137: URL: https://github.com/apache/iceberg/pull/12137 Repro: https://github.com/apache/hive/blob/master/iceberg/iceberg-handler/src/test/queries/positive/iceberg_bucket_map_join_4.q Pending: - add test for partition evolution (TestPartiti

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936437048 ## spark/v3.5/spark-runtime/NOTICE: ## @@ -244,8 +372,63 @@ This binary artifact includes Apache Arrow with the following in its NOTICE file -

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936437048 ## spark/v3.5/spark-runtime/NOTICE: ## @@ -244,8 +372,63 @@ This binary artifact includes Apache Arrow with the following in its NOTICE file -

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936424888 ## spark/v3.5/spark-runtime/NOTICE: ## @@ -497,12 +680,46 @@ file: -This binary

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
rdblue commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936424888 ## spark/v3.5/spark-runtime/NOTICE: ## @@ -497,12 +680,46 @@ file: -This binary

[PR] Build: Bump griffe from 1.5.5 to 1.5.6 [iceberg-python]

2025-01-30 Thread via GitHub
dependabot[bot] opened a new pull request, #1593: URL: https://github.com/apache/iceberg-python/pull/1593 Bumps [griffe](https://github.com/mkdocstrings/griffe) from 1.5.5 to 1.5.6. Release notes Sourced from https://github.com/mkdocstrings/griffe/releases";>griffe's releases.

Re: [PR] Spark: Support singular form of years, months, days, and hours functions [iceberg]

2025-01-30 Thread via GitHub
wypoon commented on code in PR #12117: URL: https://github.com/apache/iceberg/pull/12117#discussion_r1936330045 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/functions/DaysFunction.java: ## @@ -31,6 +31,8 @@ * A Spark function implementation for the Iceberg day tr

Re: [PR] Spark: Support singular form of years, months, days, and hours functions [iceberg]

2025-01-30 Thread via GitHub
wypoon commented on code in PR #12117: URL: https://github.com/apache/iceberg/pull/12117#discussion_r1936326700 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSparkDaysFunction.java: ## @@ -39,6 +39,9 @@ public void testDates() { assertThat(scalarSql("SE

Re: [PR] Spark: Support singular form of years, months, days, and hours functions [iceberg]

2025-01-30 Thread via GitHub
wypoon commented on code in PR #12117: URL: https://github.com/apache/iceberg/pull/12117#discussion_r1936326700 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSparkDaysFunction.java: ## @@ -39,6 +39,9 @@ public void testDates() { assertThat(scalarSql("SE

Re: [PR] Spark: support rewrite on specified target branch [iceberg]

2025-01-30 Thread via GitHub
nabaskes commented on PR #8797: URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2625474565 Is this work permanently abandoned? Is there another good way to solve this, or is this pattern just not really supported? -- This is an automated message from the Apache Git Service.

Re: [PR] chore(deps): Bump serde_json from 1.0.135 to 1.0.138 [iceberg-rust]

2025-01-30 Thread via GitHub
Fokko merged PR #929: URL: https://github.com/apache/iceberg-rust/pull/929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: Fix cleanup of orphaned statistics files in dropTableData [iceberg]

2025-01-30 Thread via GitHub
lliangyu-lin commented on PR #12132: URL: https://github.com/apache/iceberg/pull/12132#issuecomment-2625421716 @gaborkaszab I totally agree on what you mentioned. I have my own doubts on the approach as well and it's indeed very expansive, so I was hoping we can get some more eyes and opini

Re: [PR] chore(deps): Bump arrow-ord from 53.3.0 to 53.4.0 [iceberg-rust]

2025-01-30 Thread via GitHub
Fokko merged PR #930: URL: https://github.com/apache/iceberg-rust/pull/930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: add variant type support [iceberg]

2025-01-30 Thread via GitHub
amogh-jahagirdar commented on code in PR #11831: URL: https://github.com/apache/iceberg/pull/11831#discussion_r1936181802 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -61,6 +61,14 @@ private Types() {} private static final Pattern DECIMAL = Pattern.c

Re: [PR] Core: add variant type support [iceberg]

2025-01-30 Thread via GitHub
amogh-jahagirdar commented on code in PR #11831: URL: https://github.com/apache/iceberg/pull/11831#discussion_r1936176654 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -39,7 +42,7 @@ class Identity implements Transform { @Deprecated public static

Re: [PR] Core: add variant type support [iceberg]

2025-01-30 Thread via GitHub
amogh-jahagirdar commented on code in PR #11831: URL: https://github.com/apache/iceberg/pull/11831#discussion_r1894351944 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -39,7 +42,7 @@ class Identity implements Transform { @Deprecated public static

Re: [I] [Discussion] Add Avro library [iceberg-cpp]

2025-01-30 Thread via GitHub
Fokko closed issue #17: [Discussion] Add Avro library URL: https://github.com/apache/iceberg-cpp/issues/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] add iceberg_avro interface [iceberg-cpp]

2025-01-30 Thread via GitHub
Fokko merged PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [I] [Discussion] Add Avro library [iceberg-cpp]

2025-01-30 Thread via GitHub
Fokko closed issue #17: [Discussion] Add Avro library URL: https://github.com/apache/iceberg-cpp/issues/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] ci: add clang-tidy Checks [iceberg-cpp]

2025-01-30 Thread via GitHub
Fokko merged PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] chore(deps): Bump tempfile from 3.15.0 to 3.16.0 [iceberg-rust]

2025-01-30 Thread via GitHub
Fokko merged PR #931: URL: https://github.com/apache/iceberg-rust/pull/931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

[I] How get access to iceberg repository? [iceberg]

2025-01-30 Thread via GitHub
2MD opened a new issue, #12136: URL: https://github.com/apache/iceberg/issues/12136 ### Query engine _No response_ ### Question I want to fix one bug. 21:57:26.871: [iceberg] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false push --progress

Re: [PR] chore(deps): Bump aws-sdk-s3tables from 1.6.0 to 1.7.0 [iceberg-rust]

2025-01-30 Thread via GitHub
Fokko merged PR #926: URL: https://github.com/apache/iceberg-rust/pull/926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] chore(deps): Bump arrow-select from 53.3.0 to 53.4.0 [iceberg-rust]

2025-01-30 Thread via GitHub
Fokko merged PR #927: URL: https://github.com/apache/iceberg-rust/pull/927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [I] Using tables created in Hive Catalog in Hadoop catalog [iceberg]

2025-01-30 Thread via GitHub
guykhazma commented on issue #12125: URL: https://github.com/apache/iceberg/issues/12125#issuecomment-2625293633 @ajantha-bhat thanks for the pointers. As file system tables are deprecated I will close this issue. -- This is an automated message from the Apache Git Service. To respond t

Re: [I] Using tables created in Hive Catalog in Hadoop catalog [iceberg]

2025-01-30 Thread via GitHub
guykhazma closed issue #12125: Using tables created in Hive Catalog in Hadoop catalog URL: https://github.com/apache/iceberg/issues/12125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Update annotation with V3 [iceberg-python]

2025-01-30 Thread via GitHub
Fokko commented on PR #1587: URL: https://github.com/apache/iceberg-python/pull/1587#issuecomment-2625292714 Less is more, thanks @kevinjqliu 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
Fokko commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936114817 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -20,7 +103,143 @@ This binary artifact includes Apache ORC with the following in its NOTICE file: --

Re: [PR] Update annotation with V3 [iceberg-python]

2025-01-30 Thread via GitHub
kevinjqliu merged PR #1587: URL: https://github.com/apache/iceberg-python/pull/1587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Update annotation with V3 [iceberg-python]

2025-01-30 Thread via GitHub
kevinjqliu commented on PR #1587: URL: https://github.com/apache/iceberg-python/pull/1587#issuecomment-2625285068 Already added in #1554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
amogh-jahagirdar commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936109448 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -20,7 +103,143 @@ This binary artifact includes Apache ORC with the following in its NOTICE file: ---

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
Fokko commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936103070 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -20,7 +103,143 @@ This binary artifact includes Apache ORC with the following in its NOTICE file: --

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
jbonofre commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936099857 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -7,10 +6,94 @@ The Apache Software Foundation (http://www.apache.org/). --

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
Fokko commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936098464 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -7,10 +6,48 @@ The Apache Software Foundation (http://www.apache.org/). -

Re: [PR] Spark: Test metadata tables with format-version=3 [iceberg]

2025-01-30 Thread via GitHub
dramaticlly commented on code in PR #12135: URL: https://github.com/apache/iceberg/pull/12135#discussion_r1936095912 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java: ## @@ -62,6 +67,44 @@ @ExtendWith(ParameterizedTestEx

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
Fokko commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936095768 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -7,10 +6,94 @@ The Apache Software Foundation (http://www.apache.org/). -

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
jbonofre commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935966493 ## azure-bundle/NOTICE: ## @@ -7,24 +6,240 @@ The Apache Software Foundation (http://www.apache.org/). --

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
jbonofre commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935960403 ## azure-bundle/NOTICE: ## @@ -7,24 +6,240 @@ The Apache Software Foundation (http://www.apache.org/). --

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
jbonofre commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935956733 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -20,7 +57,143 @@ This binary artifact includes Apache ORC with the following in its NOTICE file:

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

2025-01-30 Thread via GitHub
jbonofre commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935956204 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -7,10 +6,48 @@ The Apache Software Foundation (http://www.apache.org/). --

  1   2   >