wypoon commented on code in PR #12117:
URL: https://github.com/apache/iceberg/pull/12117#discussion_r1936326700
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSparkDaysFunction.java:
##########
@@ -39,6 +39,9 @@ public void testDates() {
assertThat(scalarSql("SELECT system.days(date('2017-12-01'))"))
.as("Expected to produce 2017-12-01")
.isEqualTo(Date.valueOf("2017-12-01"));
+ assertThat(scalarSql("SELECT system.day(date('2017-12-01'))"))
Review Comment:
Ok, I see what you're getting at.
I decided to add constructors to the function so that we know what form
(singular or plural) is being used; singular is the default. I have accordingly
documented (in javadoc) the singular form as the first example with the plural
form as the alternate. I didn't change the names of the classes as that would
be too much work and not worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
