ajantha-bhat commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1777912510
##########
core/src/main/java/org/apache/iceberg/PartitionStats.java:
##########
@@ -249,4 +250,45 @@ public <T> void set(int pos, T value) {
throw new UnsupportedOperationException("Unknown position: " + pos);
}
}
+
+ @Override
+ @SuppressWarnings("checkstyle:CyclomaticComplexity")
+ public boolean equals(Object other) {
Review Comment:
`StructLikeMap` was previously handling this implicitly. But when
`PartitionStatsRecord` wraps `PartitionStats` now for the writers, it needs to
override `equals` and `hashcode`
##########
core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java:
##########
@@ -87,13 +90,10 @@ private static PartitionMap<PartitionStats> collectStats(
PartitionMap<PartitionStats> statsMap =
PartitionMap.create(table.specs());
int specId = manifest.partitionSpecId();
PartitionSpec spec = table.specs().get(specId);
- PartitionData keyTemplate = new PartitionData(partitionType);
for (ManifestEntry<?> entry : reader.entries()) {
ContentFile<?> file = entry.file();
- StructLike coercedPartition =
- PartitionUtil.coercePartition(partitionType, spec,
file.partition());
- StructLike key = keyTemplate.copyFor(coercedPartition);
+ Record key = coercedPartitionRecord(file, spec, partitionType);
Review Comment:
Need `Record` instead of `PartitionData` for the writers.
Cannot keep this conversion in the data module as it just to wraps the same
`PartitionStats` object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
