tusharchou commented on code in PR #1388:
URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1936663741
##########
pyiceberg/expressions/visitors.py:
##########
@@ -1731,3 +1731,214 @@ def _can_contain_nulls(self, field_id: int) -> bool:
def _can_contain_nans(self, field_id: int) -> bool:
return (nan_count := self.nan_counts.get(field_id)) is not None and
nan_count > 0
+
+
+class ResidualVisitor(BoundBooleanExpressionVisitor[BooleanExpression], ABC):
+ schema: Schema
+ spec: PartitionSpec
+ case_sensitive: bool
+
+ def __init__(self, schema: Schema, spec: PartitionSpec, case_sensitive:
bool, expr: BooleanExpression):
+ self.schema = schema
+ self.spec = spec
+ self.case_sensitive = case_sensitive
+ self.expr = expr
+
+ def eval(self, partition_data: Record) -> BooleanExpression:
+ self.struct = partition_data
+ return visit(self.expr, visitor=self)
+
+ def visit_true(self) -> BooleanExpression:
+ return AlwaysTrue()
+
+ def visit_false(self) -> BooleanExpression:
+ return AlwaysFalse()
+
+ def visit_not(self, child_result: BooleanExpression) -> BooleanExpression:
+ return Not(child_result)
+
+ def visit_and(self, left_result: BooleanExpression, right_result:
BooleanExpression) -> BooleanExpression:
+ return And(left_result, right_result)
+
+ def visit_or(self, left_result: BooleanExpression, right_result:
BooleanExpression) -> BooleanExpression:
+ return Or(left_result, right_result)
+
+ def visit_is_null(self, term: BoundTerm[L]) -> BooleanExpression:
+ if term.eval(self.struct) is None:
+ return AlwaysTrue()
+ else:
+ return AlwaysFalse()
+
+ def visit_not_null(self, term: BoundTerm[L]) -> BooleanExpression:
+ if term.eval(self.struct) is not None:
+ return AlwaysTrue()
+ else:
+ return AlwaysFalse()
+
+ def visit_is_nan(self, term: BoundTerm[L]) -> BooleanExpression:
+ val = term.eval(self.struct)
+ if val is None:
+ return self.visit_true()
+ else:
+ return self.visit_false()
+
+ def visit_not_nan(self, term: BoundTerm[L]) -> BooleanExpression:
+ val = term.eval(self.struct)
+ if val is not None:
+ return self.visit_true()
+ else:
+ return self.visit_false()
Review Comment:
@Fokko I would require some help here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
