amogh-jahagirdar commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936109448


##########
flink/v1.20/flink-runtime/NOTICE:
##########
@@ -20,7 +103,143 @@ This binary artifact includes Apache ORC with the 
following in its NOTICE file:
 
 
--------------------------------------------------------------------------------
 
-This binary artifact includes Airlift Aircompressor with the following in its
+This binary artifact includes Apache Parquet 1.15.0 with the following in its 
NOTICE file:
+
+| Apache Parquet Java
+| Copyright 2014-2024 The Apache Software Foundation
+|
+| This product includes software developed at
+| The Apache Software Foundation (http://www.apache.org/).
+|
+| 
--------------------------------------------------------------------------------
+|
+| This product includes parquet-tools, initially developed at ARRIS, Inc. with

Review Comment:
   Yeah I think for now we should just copy the content of the NOTICE as is for 
the particular version of the dependency we are bundling. If there's some issue 
in the upstream project's notice, we can fix that there and update our NOTICE 
after the dependency is released? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to