rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1936491473
########## core/src/main/java/org/apache/iceberg/variants/Variants.java: ########## @@ -209,59 +213,59 @@ public static VariantPrimitive<Void> ofNull() { return new PrimitiveWrapper<>(PhysicalType.NULL, null); } - static VariantPrimitive<Boolean> of(boolean value) { + public static VariantPrimitive<Boolean> of(boolean value) { Review Comment: Needed to expose these to create test values in the Parquet package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org