Re: [PR] Build: Bump griffe from 1.5.4 to 1.5.5 [iceberg-python]

2025-01-16 Thread via GitHub
Fokko merged PR #1528: URL: https://github.com/apache/iceberg-python/pull/1528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] fix: remove check-docstring-first pre-commit check [iceberg-python]

2025-01-16 Thread via GitHub
Fokko commented on PR #1531: URL: https://github.com/apache/iceberg-python/pull/1531#issuecomment-2597620177 @rodrigc Appreciate the work, thanks for taking the time! Can I suggested instead of removing the check, should we replace it with one that you suggested? -- This is an automated m

Re: [PR] Spark 3.3: Backport support for default values [iceberg]

2025-01-16 Thread via GitHub
Fokko commented on PR #11988: URL: https://github.com/apache/iceberg/pull/11988#issuecomment-2597617142 > Do we still want to back-port new features to Spark 3.3 given its support is deprecated? I think it is best to keep the Spark versions as close as possible 👍 -- This is an aut

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
Fokko commented on code in PR #11986: URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919680421 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ## @@ -721,9 +725,4 @@ public DeleteGranularity deleteGranularity() { .defaultV

Re: [PR] WIP: Add headers for type/field/schema [iceberg-cpp]

2025-01-16 Thread via GitHub
lidavidm commented on code in PR #31: URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1919659067 ## src/iceberg/type.h: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOT

Re: [PR] WIP: Add headers for type/field/schema [iceberg-cpp]

2025-01-16 Thread via GitHub
lidavidm commented on PR #31: URL: https://github.com/apache/iceberg-cpp/pull/31#issuecomment-2597595950 I added Primitive/NestedType; I'll start filling out definitions and the rest of the types next, along with adding the visitors to iceberg-arrow. -- This is an automated message from t

Re: [PR] WIP: Add headers for type/field/schema [iceberg-cpp]

2025-01-16 Thread via GitHub
lidavidm commented on code in PR #31: URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1919669923 ## src/iceberg/type.h: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOT

Re: [PR] WIP: Add headers for type/field/schema [iceberg-cpp]

2025-01-16 Thread via GitHub
lidavidm commented on code in PR #31: URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1919662198 ## src/iceberg/schema.h: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [PR] WIP: Add headers for type/field/schema [iceberg-cpp]

2025-01-16 Thread via GitHub
lidavidm commented on code in PR #31: URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1919661788 ## src/iceberg/type.h: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOT

Re: [PR] Doc: Add missing content value to manifests table [iceberg]

2025-01-16 Thread via GitHub
nastra merged PR #11989: URL: https://github.com/apache/iceberg/pull/11989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Build: Add plugin to generate license and notice files [iceberg]

2025-01-16 Thread via GitHub
snazy commented on PR #11977: URL: https://github.com/apache/iceberg/pull/11977#issuecomment-2597552634 > This was not copied from another project, we have used this in Iceberg before Polaris existed, but simply didn't contribute the code. [#8261 (comment)](https://github.com/apache/iceberg

Re: [PR] Parquet: Add readers and writers for the internal object model [iceberg]

2025-01-16 Thread via GitHub
ajantha-bhat commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1918344913 ## parquet/src/main/java/org/apache/iceberg/data/parquet/GenericParquetReaders.java: ## @@ -92,4 +151,124 @@ protected void set(Record struct, int pos, Object va

Re: [PR] Parquet: Add readers and writers for the internal object model [iceberg]

2025-01-16 Thread via GitHub
ajantha-bhat commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1918344913 ## parquet/src/main/java/org/apache/iceberg/data/parquet/GenericParquetReaders.java: ## @@ -92,4 +151,124 @@ protected void set(Record struct, int pos, Object va

Re: [PR] Parquet: Add readers and writers for the internal object model [iceberg]

2025-01-16 Thread via GitHub
ajantha-bhat commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917518515 ## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java: ## @@ -76,6 +67,31 @@ protected ParquetValueReader createReader( protected a

Re: [PR] Parquet: Add readers and writers for the internal object model [iceberg]

2025-01-16 Thread via GitHub
ajantha-bhat commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1918338951 ## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java: ## @@ -76,6 +67,31 @@ protected ParquetValueReader createReader( protected a

Re: [PR] Parquet: Add readers and writers for the internal object model [iceberg]

2025-01-16 Thread via GitHub
ajantha-bhat commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1919615649 ## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java: ## @@ -397,7 +404,7 @@ public ParquetValueReader primitive( case INT96

Re: [PR] fix: spark version in integration_tests [iceberg-rust]

2025-01-16 Thread via GitHub
liurenjie1024 merged PR #894: URL: https://github.com/apache/iceberg-rust/pull/894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] fix: spark version in integration_tests [iceberg-rust]

2025-01-16 Thread via GitHub
liurenjie1024 commented on PR #894: URL: https://github.com/apache/iceberg-rust/pull/894#issuecomment-2597512269 > PyIceberg is currently blocked on using `3.5.4` so we have to use `archive.apache.org` for the older version. > > If we use `dlcdn.apache.org`, we would run into this iss

Re: [PR] refine: refine interface of ManifestWriter [iceberg-rust]

2025-01-16 Thread via GitHub
liurenjie1024 commented on code in PR #738: URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1919610030 ## crates/iceberg/src/spec/manifest.rs: ## @@ -114,6 +114,70 @@ impl Manifest { } } +/// The builder used to create a [`ManifestWriter`]. +pub struct M

Re: [PR] Parquet: Add readers and writers for the internal object model [iceberg]

2025-01-16 Thread via GitHub
ajantha-bhat commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1918335337 ## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java: ## @@ -397,7 +404,7 @@ public ParquetValueReader primitive( case INT96

Re: [I] [Discussion] Add Avro library [iceberg-cpp]

2025-01-16 Thread via GitHub
zhjwpku commented on issue #17: URL: https://github.com/apache/iceberg-cpp/issues/17#issuecomment-2597469266 > I believe I have a lot of TODOs on my end, especially the internal project from my employer :) > > It would be great if you have time to do it. Ok, I will prepare a PR

Re: [PR] Core: Unimplement Map from CharSequenceMap to obey contract [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on PR #11704: URL: https://github.com/apache/iceberg/pull/11704#issuecomment-2597469594 I'm catching up on this discussion but at least in the context of a 1.8 release, it doesn't seem like there's a consensus yet so I'm going to remove this PR from the release mi

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11986: URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919579513 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ## @@ -723,7 +727,6 @@ public DeleteGranularity deleteGranularity() { }

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11986: URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919571061 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ## @@ -721,9 +725,4 @@ public DeleteGranularity deleteGranularity() {

Re: [PR] Spark 3.4: Backport support for default values [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar merged PR #11987: URL: https://github.com/apache/iceberg/pull/11987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Spark 3.4: Backport support for default values [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on PR #11987: URL: https://github.com/apache/iceberg/pull/11987#issuecomment-2597462630 Thanks @rdblue! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Spark 3.4: Backport support for default values [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11987: URL: https://github.com/apache/iceberg/pull/11987#discussion_r1919575006 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkAvroReader.java: ## @@ -20,45 +20,53 @@ import static org.apache.iceberg.spark.da

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11986: URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919572654 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ## @@ -214,6 +214,10 @@ private boolean fanoutWriterEnabled(boolean defaultVa

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11986: URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919571061 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ## @@ -721,9 +725,4 @@ public DeleteGranularity deleteGranularity() {

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11986: URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919564959 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ## @@ -723,7 +727,6 @@ public DeleteGranularity deleteGranularity() { }

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11986: URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919564959 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ## @@ -723,7 +727,6 @@ public DeleteGranularity deleteGranularity() { }

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11986: URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919564959 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ## @@ -723,7 +727,6 @@ public DeleteGranularity deleteGranularity() { }

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11986: URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919564959 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ## @@ -723,7 +727,6 @@ public DeleteGranularity deleteGranularity() { }

Re: [I] Validation Error in ConfigResponse Model When connecting Nessie with PyIceberg using RestCatalog [iceberg-python]

2025-01-16 Thread via GitHub
heman026 commented on issue #1524: URL: https://github.com/apache/iceberg-python/issues/1524#issuecomment-2597444021 > > You can safely use your current Nessie applications, those that use type=nessie when using Iceberg, concurrently with applications using Nessie via Iceberg REST (type=re

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11986: URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919554870 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ## @@ -723,7 +727,6 @@ public DeleteGranularity deleteGranularity() { }

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11986: URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919554870 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ## @@ -723,7 +727,6 @@ public DeleteGranularity deleteGranularity() { }

Re: [I] [Discussion] Add Avro library [iceberg-cpp]

2025-01-16 Thread via GitHub
wgtmac commented on issue #17: URL: https://github.com/apache/iceberg-cpp/issues/17#issuecomment-2597419682 I believe I have a lot of TODOs on my end, especially the internal project from my employer :) It would be great if you have time to do it. -- This is an automated message fr

Re: [PR] ci: add clang-tidy Checks [iceberg-cpp]

2025-01-16 Thread via GitHub
zhjwpku commented on PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2597414406 > As the docs state, that's for Objective-C, so I wouldn't expect it to help Yeah, I did not notice that ;( -- This is an automated message from the Apache Git Service. To respond

Re: [I] [Discussion] Add Avro library [iceberg-cpp]

2025-01-16 Thread via GitHub
zhjwpku commented on issue #17: URL: https://github.com/apache/iceberg-cpp/issues/17#issuecomment-2597412056 > After [apache/avro#3293](https://github.com/apache/avro/pull/3293) is merged, I think we are ready to use it. [@zhjwpku](https://github.com/zhjwpku) Great, will keep an eye o

Re: [I] [Discussion] Add Avro library [iceberg-cpp]

2025-01-16 Thread via GitHub
wgtmac commented on issue #17: URL: https://github.com/apache/iceberg-cpp/issues/17#issuecomment-2597400734 After https://github.com/apache/avro/pull/3293 is merged, I think we are ready to use it. @zhjwpku -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] ci: add clang-tidy Checks [iceberg-cpp]

2025-01-16 Thread via GitHub
lidavidm commented on PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2597391057 As the docs state, that's for Objective-C, so I wouldn't expect it to help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Support WASB scheme in ADLSFileIO [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11830: URL: https://github.com/apache/iceberg/pull/11830#discussion_r1919521749 ## core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java: ## @@ -62,7 +62,9 @@ public class ResolvingFileIO implements HadoopConfigurable, DelegateF

Re: [PR] Spark 3.3: Backport support for default values [iceberg]

2025-01-16 Thread via GitHub
manuzhang commented on PR #11988: URL: https://github.com/apache/iceberg/pull/11988#issuecomment-2597383779 Do we still want to back-port new features to Spark 3.3 given its support is deprecated? -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Spark 3.4: Backport support for default values [iceberg]

2025-01-16 Thread via GitHub
rdblue commented on code in PR #11987: URL: https://github.com/apache/iceberg/pull/11987#discussion_r1919504716 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkOrcReader.java: ## @@ -62,8 +62,7 @@ public void writeAndValidateRepeatingRecords() throws IO

Re: [PR] Spark 3.3: Backport support for default values [iceberg]

2025-01-16 Thread via GitHub
rdblue commented on code in PR #11988: URL: https://github.com/apache/iceberg/pull/11988#discussion_r1919506979 ## spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/data/AvroDataTest.java: ## @@ -244,6 +286,285 @@ public void testTimestampWithoutZone() throws IOException

Re: [PR] Spark 3.3: Backport support for default values [iceberg]

2025-01-16 Thread via GitHub
rdblue commented on code in PR #11988: URL: https://github.com/apache/iceberg/pull/11988#discussion_r1919505925 ## spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/data/AvroDataTest.java: ## @@ -65,7 +91,7 @@ public abstract class AvroDataTest { required(117, "

Re: [PR] Spark 3.4: Backport support for default values [iceberg]

2025-01-16 Thread via GitHub
rdblue commented on code in PR #11987: URL: https://github.com/apache/iceberg/pull/11987#discussion_r1919504140 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkAvroReader.java: ## @@ -20,45 +20,53 @@ import static org.apache.iceberg.spark.data.TestHel

Re: [PR] ci: add clang-tidy Checks [iceberg-cpp]

2025-01-16 Thread via GitHub
zhjwpku commented on PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2597357820 > Should we just follow what [Arrow](https://arrow.apache.org/docs/developers/cpp/development.html#code-style-linting-and-ci) does and adjust it as needed? I think it is based on the Goog

[PR] Spark 3.3: Backport support for default values [iceberg]

2025-01-16 Thread via GitHub
rdblue opened a new pull request, #11988: URL: https://github.com/apache/iceberg/pull/11988 This backports support for default values from 3.5. Each PR is backported as a separate commit: #11299, #11803, #11811, #11815, and #11832. This contains the same changes as #11987. --

[PR] Spark 3.4: Backport support for default values [iceberg]

2025-01-16 Thread via GitHub
rdblue opened a new pull request, #11987: URL: https://github.com/apache/iceberg/pull/11987 This backports support for default values from 3.5. Each PR is backported as a separate commit: #11299, #11803, #11811, #11815, and #11832. -- This is an automated message from the Apache Gi

Re: [PR] docs: Add docstrings for Identifier, Properties, RecursiveDict [iceberg-python]

2025-01-16 Thread via GitHub
rodrigc commented on PR #1530: URL: https://github.com/apache/iceberg-python/pull/1530#issuecomment-2597351863 @pawamoy I submitted a separate PR: https://github.com/apache/iceberg-python/pull/1531 to remove `check-docstring-first` -- This is an automated message from the Apache Git Serv

Re: [PR] fix: remove check-docstring-first pre-commit check [iceberg-python]

2025-01-16 Thread via GitHub
rodrigc commented on PR #1531: URL: https://github.com/apache/iceberg-python/pull/1531#issuecomment-2597351391 In the discussion of https://github.com/pre-commit/pre-commit-hooks/issues/159 , Several other projects chose to remove this check such as: https://github.com/DanielNoord/j

Re: [PR] fix: remove check-docstring-first pre-commit check [iceberg-python]

2025-01-16 Thread via GitHub
rodrigc commented on PR #1531: URL: https://github.com/apache/iceberg-python/pull/1531#issuecomment-2597352132 This is needed for this PR: https://github.com/apache/iceberg-python/pull/1530 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] feat: add file_io and local fs impl [iceberg-cpp]

2025-01-16 Thread via GitHub
zhjwpku commented on PR #30: URL: https://github.com/apache/iceberg-cpp/pull/30#issuecomment-2597349794 > > Can we provide both? > > I think we can. It is pretty straight-forward to do something similar to `arrow::RandomnAccessFile`: https://github.com/apache/arrow/blob/main/cpp/src/

[PR] fix: remove check-docstring-first pre-commit check [iceberg-python]

2025-01-16 Thread via GitHub
rodrigc opened a new pull request, #1531: URL: https://github.com/apache/iceberg-python/pull/1531 This check gives false positives on attribute docstrings with warnings such as: - "Multiple module docstrings (first docstring on line N)", or - "Module docstring appears after code

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11986: URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919488304 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java: ## @@ -798,14 +798,14 @@ private static class Context impleme

Re: [PR] docs: Add docstrings for Identifier, Properties, RecursiveDict [iceberg-python]

2025-01-16 Thread via GitHub
rodrigc commented on PR #1530: URL: https://github.com/apache/iceberg-python/pull/1530#issuecomment-2597332238 I see what you are saying. It looks like this issue has come up before: https://github.com/pre-commit/pre-commit-hooks/issues/159 This project chose to remove the check-do

Re: [PR] Spark: Fix Puffin suffix for DV files [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on PR #11986: URL: https://github.com/apache/iceberg/pull/11986#issuecomment-2597330009 Working on a good place to add tests for this...we generally don't test against the actual file paths in Iceberg since they're not necessary for correctness but in this case it

Re: [PR] feat: add file_io and local fs impl [iceberg-cpp]

2025-01-16 Thread via GitHub
wgtmac commented on PR #30: URL: https://github.com/apache/iceberg-cpp/pull/30#issuecomment-2597327334 > Can we provide both? I think we can. It is pretty straight-forward to do something similar to `arrow::RandomnAccessFile`: https://github.com/apache/arrow/blob/main/cpp/src/arrow/i

Re: [PR] WIP: Add headers for type/field/schema [iceberg-cpp]

2025-01-16 Thread via GitHub
wgtmac commented on code in PR #31: URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1919463629 ## src/iceberg/type_fwd.h: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [I] Creating Delete Vectors using Java API or Spark [iceberg]

2025-01-16 Thread via GitHub
amogh-jahagirdar commented on issue #11968: URL: https://github.com/apache/iceberg/issues/11968#issuecomment-2597296564 @Fokko is this spark 3.5? I'll have a backport up for 3.4 shortly, so if it's 3.4 or earlier you're probably not going to see those? -- This is an automated message fro

Re: [PR] ci: add clang-tidy Checks [iceberg-cpp]

2025-01-16 Thread via GitHub
lidavidm commented on PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2597296054 > Should we just follow what [Arrow](https://arrow.apache.org/docs/developers/cpp/development.html#code-style-linting-and-ci) does and adjust it as needed? I think it is based on the Goo

Re: [I] A casting error occurs when Sanitizing the expression value in a specific case. [iceberg]

2025-01-16 Thread via GitHub
dmgkeke closed issue #11932: A casting error occurs when Sanitizing the expression value in a specific case. URL: https://github.com/apache/iceberg/issues/11932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] ci: add clang-tidy Checks [iceberg-cpp]

2025-01-16 Thread via GitHub
zhjwpku commented on PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2597283325 > More generally: is there a particular style guide (e.g. Google, LLVM, ...) that we want to adopt? I didn't find such one line setting, this PR sets lots of readability-identifier

Re: [PR] ci: add clang-tidy Checks [iceberg-cpp]

2025-01-16 Thread via GitHub
wgtmac commented on PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2597282759 Should we just follow what [Arrow](https://arrow.apache.org/docs/developers/cpp/development.html#code-style-linting-and-ci) does and adjust it as needed? I think it is based on the Google

Re: [PR] docs: Add docstrings for Identifier, Properties, RecursiveDict [iceberg-python]

2025-01-16 Thread via GitHub
pawamoy commented on PR #1530: URL: https://github.com/apache/iceberg-python/pull/1530#issuecomment-2597266654 Docstrings must definitely be written *below* attribute assignments for mkdocstrings to pick them up. I'd recommend disabling this lint rule as it apparently doesn't support code w

Re: [PR] docs: Add docstrings for Identifier, Properties, RecursiveDict [iceberg-python]

2025-01-16 Thread via GitHub
rodrigc commented on code in PR #1530: URL: https://github.com/apache/iceberg-python/pull/1530#discussion_r1919447875 ## pyiceberg/typedef.py: ## @@ -74,8 +74,14 @@ def __missing__(self, key: K) -> V: Identifier = Tuple[str, ...] +"""Type for identifiers in PyIceberg.""" R

Re: [I] Add update-statement support in the Flink engine [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on issue #9517: URL: https://github.com/apache/iceberg/issues/9517#issuecomment-2597166616 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [PR] Core, API, Spec: Metadata Row Lineage [iceberg]

2025-01-16 Thread via GitHub
HonahX commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1919418195 ## core/src/main/java/org/apache/iceberg/TableMetadataParser.java: ## @@ -110,6 +110,8 @@ private TableMetadataParser() {} static final String METADATA_LOG = "metad

Re: [PR] Core, API, Spec: Metadata Row Lineage [iceberg]

2025-01-16 Thread via GitHub
HonahX commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1919418195 ## core/src/main/java/org/apache/iceberg/TableMetadataParser.java: ## @@ -110,6 +110,8 @@ private TableMetadataParser() {} static final String METADATA_LOG = "metad

Re: [PR] docs: Add docstrings for Identifier, Properties, RecursiveDict [iceberg-python]

2025-01-16 Thread via GitHub
rodrigc commented on PR #1530: URL: https://github.com/apache/iceberg-python/pull/1530#issuecomment-2597207467 The issue with the linter is that it does not allow docstrings to appear after the variable. For this code: ``` Identifier = Tuple[str, ...] """A tuple of string

Re: [PR] Core, API, Spec: Metadata Row Lineage [iceberg]

2025-01-16 Thread via GitHub
HonahX commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1919411746 ## core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] docs: Add docstrings for Identifier, Properties, RecursiveDict [iceberg-python]

2025-01-16 Thread via GitHub
kevinjqliu commented on code in PR #1530: URL: https://github.com/apache/iceberg-python/pull/1530#discussion_r1919407904 ## pyiceberg/typedef.py: ## @@ -74,8 +74,14 @@ def __missing__(self, key: K) -> V: Identifier = Tuple[str, ...] +"""Type for identifiers in PyIceberg."""

Re: [PR] ci: add clang-tidy Checks [iceberg-cpp]

2025-01-16 Thread via GitHub
lidavidm commented on PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2597182577 More generally: is there a particular style guide (e.g. Google, LLVM, ...) that we want to adopt? -- This is an automated message from the Apache Git Service. To respond to the message

Re: [I] If iceberg's parquet data file contains an array of time type, it cannot be read by spark library even after dropping this column [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] closed issue #9446: If iceberg's parquet data file contains an array of time type, it cannot be read by spark library even after dropping this column URL: https://github.com/apache/iceberg/issues/9446 -- This is an automated message from the Apache Git Service. To respond

Re: [I] Caused by: java.net.SocketException: Connection reset [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] closed issue #9444: Caused by: java.net.SocketException: Connection reset URL: https://github.com/apache/iceberg/issues/9444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] How to connect apache iceberg to minio [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] closed issue #9205: How to connect apache iceberg to minio URL: https://github.com/apache/iceberg/issues/9205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Cannot drop table with AWS Glue Catalog [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on issue #9586: URL: https://github.com/apache/iceberg/issues/9586#issuecomment-2597166739 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] The topic of Indicator Monitoring [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] closed issue #9581: The topic of Indicator Monitoring URL: https://github.com/apache/iceberg/issues/9581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] The topic of Indicator Monitoring [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on issue #9581: URL: https://github.com/apache/iceberg/issues/9581#issuecomment-2597166724 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [PR] Docs: add note for `day` transform [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on PR #11749: URL: https://github.com/apache/iceberg/pull/11749#issuecomment-2597166951 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Fix comment on `WRITE_OBJECT_STORE_PARTITIONED_PATHS` table property [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on PR #11798: URL: https://github.com/apache/iceberg/pull/11798#issuecomment-2597167000 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [I] about query snapshotId [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on issue #9558: URL: https://github.com/apache/iceberg/issues/9558#issuecomment-2597166672 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [PR] Spark: DVs + Positional Deletes [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on PR #11545: URL: https://github.com/apache/iceberg/pull/11545#issuecomment-2597166876 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core, Spark: Include content offset/size in PositionDeletesTable [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on PR #11675: URL: https://github.com/apache/iceberg/pull/11675#issuecomment-2597166902 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [I] about report [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on issue #9560: URL: https://github.com/apache/iceberg/issues/9560#issuecomment-2597166698 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] about query snapshotId [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] closed issue #9558: about query snapshotId URL: https://github.com/apache/iceberg/issues/9558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [I] Recover dataset from the bug introduced by https://github.com/apache/iceberg/issues/8953 [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on issue #9509: URL: https://github.com/apache/iceberg/issues/9509#issuecomment-2597166567 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Recover dataset from the bug introduced by https://github.com/apache/iceberg/issues/8953 [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] closed issue #9509: Recover dataset from the bug introduced by https://github.com/apache/iceberg/issues/8953 URL: https://github.com/apache/iceberg/issues/9509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] about report [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] closed issue #9560: about report URL: https://github.com/apache/iceberg/issues/9560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Two-level parquet read EOF error: org.apache.parquet.io.ParquetDecodingException: Can't read value in column [a, array] repeated int32 array = 2 at value 4 out of 4 in current page. repetition

2025-01-16 Thread via GitHub
github-actions[bot] closed issue #9497: Two-level parquet read EOF error: org.apache.parquet.io.ParquetDecodingException: Can't read value in column [a, array] repeated int32 array = 2 at value 4 out of 4 in current page. repetition level: -1, definition level: -1 URL: https://github.com/apac

Re: [I] Enhancement of ViewMetadata [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on issue #9514: URL: https://github.com/apache/iceberg/issues/9514#issuecomment-2597166592 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] flink has implemented the delete and update syntax support in batch mode in a later version. Will the iceberg community implement this feature [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] closed issue #9476: flink has implemented the delete and update syntax support in batch mode in a later version. Will the iceberg community implement this feature URL: https://github.com/apache/iceberg/issues/9476 -- This is an automated message from the Apache Git Servic

Re: [I] Apache Iceberg - Branch cannot be merged using the fast_forward procedure [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] closed issue #9553: Apache Iceberg - Branch cannot be merged using the fast_forward procedure URL: https://github.com/apache/iceberg/issues/9553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] `write.parquet.compression-codec` being set even if file-format is not parquet [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] closed issue #9490: `write.parquet.compression-codec` being set even if file-format is not parquet URL: https://github.com/apache/iceberg/issues/9490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Flink throw an exception while reading table data through icebergsource [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on issue #9188: URL: https://github.com/apache/iceberg/issues/9188#issuecomment-2597166030 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] kerberos beeline insert iceberg fail error: Job commit failed: org.apache.iceberg.hive.RuntimeMetaException: Failed to connect to Hive Metastore [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on issue #9475: URL: https://github.com/apache/iceberg/issues/9475#issuecomment-2597166474 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Add update-statement support in the Flink engine [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] closed issue #9517: Add update-statement support in the Flink engine URL: https://github.com/apache/iceberg/issues/9517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] Data: Errors in some file readers do not report the file in which they failed [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on issue #9458: URL: https://github.com/apache/iceberg/issues/9458#issuecomment-2597166432 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] REST Spec: Server-side Metadata Tables [iceberg]

2025-01-16 Thread via GitHub
github-actions[bot] commented on issue #10645: URL: https://github.com/apache/iceberg/issues/10645#issuecomment-2597166763 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

  1   2   3   >