amogh-jahagirdar commented on code in PR #11987:
URL: https://github.com/apache/iceberg/pull/11987#discussion_r1919575006
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkAvroReader.java:
##########
@@ -20,45 +20,53 @@
import static org.apache.iceberg.spark.data.TestHelpers.assertEqualsUnsafe;
-import java.io.File;
import java.io.IOException;
import java.util.List;
import org.apache.avro.generic.GenericData.Record;
-import org.apache.iceberg.Files;
import org.apache.iceberg.Schema;
import org.apache.iceberg.avro.Avro;
import org.apache.iceberg.avro.AvroIterable;
+import org.apache.iceberg.inmemory.InMemoryOutputFile;
import org.apache.iceberg.io.FileAppender;
+import org.apache.iceberg.io.OutputFile;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.apache.spark.sql.catalyst.InternalRow;
-import org.junit.Assert;
public class TestSparkAvroReader extends AvroDataTest {
@Override
protected void writeAndValidate(Schema schema) throws IOException {
- List<Record> expected = RandomData.generateList(schema, 100, 0L);
+ writeAndValidate(schema, schema);
+ }
+
+ @Override
+ protected void writeAndValidate(Schema writeSchema, Schema expectedSchema)
throws IOException {
+ List<Record> expected = RandomData.generateList(writeSchema, 100, 0L);
- File testFile = temp.newFile();
- Assert.assertTrue("Delete should succeed", testFile.delete());
+ OutputFile outputFile = new InMemoryOutputFile();
Review Comment:
Yeah I compared it side by side with the original, I think the changes made
are reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
