zhjwpku commented on PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2597357820
> Should we just follow what [Arrow](https://arrow.apache.org/docs/developers/cpp/development.html#code-style-linting-and-ci) does and adjust it as needed? I think it is based on the Google coding style with some modifications and some contributors are already familiar with it. > > I have also checked that Impala has derived from the Google style as well: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536. @gaborkaszab WDYT? I do notice that there is a google-objc-function-naming[1] check, but it seems does report the anomaly(see [2]), i.e. `printPuffin` not reported. [1] https://releases.llvm.org/12.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/google-objc-function-naming.html [2] https://github.com/zhjwpku/iceberg-cpp/pull/2/files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
