kevinjqliu commented on code in PR #1530:
URL: https://github.com/apache/iceberg-python/pull/1530#discussion_r1919407904
##########
pyiceberg/typedef.py:
##########
@@ -74,8 +74,14 @@ def __missing__(self, key: K) -> V:
Identifier = Tuple[str, ...]
+"""Type for identifiers in PyIceberg."""
Review Comment:
Since the hyperlink will show this docstring, lets add something more
descriptive.
Perhaps something like
```
Identifier = Tuple[str, ...]
"""A tuple of strings representing a table identifier.
Each string in the tuple represents a part of the table's unique path. For
example,
a table in a namespace might be identified as:
("namespace", "table_name")
Examples:
>>> identifier: Identifier = ("namespace", "table_name")
"""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
