liurenjie1024 commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1919610030
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -114,6 +114,70 @@ impl Manifest {
}
}
+/// The builder used to create a [`ManifestWriter`].
+pub struct ManifestWriterBuilder {
+ output: OutputFile,
+ snapshot_id: i64,
+ key_metadata: Vec<u8>,
+ schema: SchemaRef,
+ partition_spec: PartitionSpec,
+}
+
+impl ManifestWriterBuilder {
+ /// Create a new builder.
+ pub fn new(
+ output: OutputFile,
+ snapshot_id: i64,
Review Comment:
I think we should use some special value like -1 here. The reason it's
optional is that when we append a data file here, the snapshot id is unknown.
Actual snapshot id is determined when do commit, which may fail and retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
