rdblue commented on code in PR #11988:
URL: https://github.com/apache/iceberg/pull/11988#discussion_r1919505925
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/data/AvroDataTest.java:
##########
@@ -65,7 +91,7 @@ public abstract class AvroDataTest {
required(117, "dec_38_10", Types.DecimalType.of(38, 10)) // Spark's
maximum precision
);
- @Rule public TemporaryFolder temp = new TemporaryFolder();
+ @TempDir protected Path temp;
Review Comment:
As I mentioned on the PR for 3.4, this JUnit 4 temp folder wasn't working
for JUnit 5 parameterized tests. I made some tests independent of this (to keep
the backport small) and ended up porting subclasses of `AvroDataTest` to JUnit
5 in a larger backport.
These test changes were the only significant deviations from the original
PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
