amogh-jahagirdar commented on code in PR #11986:
URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919488304
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -798,14 +798,14 @@ private static class Context implements Serializable {
this.dataFileFormat = writeConf.dataFileFormat();
this.targetDataFileSize = writeConf.targetDataFileSize();
this.deleteSparkType = info.rowIdSchema().get();
- this.deleteFileFormat = writeConf.deleteFileFormat();
+ this.useDVs = writeConf.useDVs();
+ this.deleteFileFormat = useDVs ? FileFormat.PUFFIN :
writeConf.deleteFileFormat();
Review Comment:
actually, we should probably just get this from the conf (embed the logic to
determine if DVs are used there)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
