Vinzenz Feenstra has posted comments on this change.
Change subject: db: Remove RenameManagementNetwork stored procedure
..
Patch Set 1:
I have verified the patch, however I am waiting for the setup plugins patch to
be merged
Vinzenz Feenstra has uploaded a new change for review.
Change subject: db: Remove RenameManagementNetwork stored procedure
..
db: Remove RenameManagementNetwork stored procedure
This stored procedure is no longer necessary and u
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Introduction of new TimeZone Complex Type
..
Patch Set 7:
* Tested VM Creation with the new and the old timezone/time_zone fields
* Tested VM TimeZon
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting
..
Patch Set 14:
The output is reported as expected:
Europe/Prague
+01:00
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Introduction of new TimeZone Complex Type
..
Patch Set 7:
Please disregard the previous, comment it was meant for the other patch.
--
To view, visi
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Introduction of new TimeZone Complex Type
..
Patch Set 7:
Output reported as expected:
Europe/Prague
+01:00
x
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/41813
To unsubscribe, v
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting
..
Patch Set 13:
(3 comments)
https://gerrit.ovirt.org/#/c/41813/13/backend/manager/modules/re
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/41813
To unsubscribe, v
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Send an automatic refresh if the version changed
..
Send an automatic refresh if the version changed
Change-Id: I4b53609644438f661d8db1025e609b4b8d4efc7e
Sig
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Fix exceptions on guest os reporting
..
Fix exceptions on guest os reporting
Change-Id: I626081377ca6eb25588f4fc42aa70af7048ab7bd
Signed-off-by: Vinzenz Feen
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting
..
Patch Set 11: -Verified
Found a bug - Time is not reported in seconds but minutes.
--
To v
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/41813
To unsubscribe, v
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Introduction of new TimeZone Complex Type
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/42150
To unsubscribe, visit https://
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/41813/4/backend/manager/modules/rest
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Introduction of new TimeZone Complex Type
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/42150/1/backend/manager/modules/restapi/interfac
Vinzenz Feenstra has posted comments on this change.
Change subject: backend: Added missing mapping for Australia/Darwin
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42149
To unsubscribe, visit https:/
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/41813
To unsubscribe, vi
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Introduction of new TimeZone Complex Type
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/42150
To unsubscribe, visit https://
Vinzenz Feenstra has uploaded a new change for review.
Change subject: backend: Added missing mapping for Australia/Darwin
..
backend: Added missing mapping for Australia/Darwin
Change-Id: I673e099a61d8e9e63e1bb380a19446c0edf2da
Vinzenz Feenstra has uploaded a new change for review.
Change subject: restapi: Introduction of new TimeZone Complex Type
..
restapi: Introduction of new TimeZone Complex Type
This patch introduces a new complex type TimeZone.
T
Vinzenz Feenstra has posted comments on this change.
Change subject: Adding atomic host support to the ovirt guest agent
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39750
To unsubscribe, visit http
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Adding atomic host support to the ovirt guest agent
..
Adding atomic host support to the ovirt guest agent
Change-Id: Id7c2d8b00ce4fab7dc61e449a012a8
Vinzenz Feenstra has posted comments on this change.
Change subject: Adding atomic host support to the ovirt guest agent
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/39750/3/ovirt-guest-agent/GuestAgentLinux2.py
Fi
Vinzenz Feenstra has posted comments on this change.
Change subject: Adding atomic host support to the guest agent
..
Patch Set 4: Verified+1
Tested @ ATOMIC RHEL (tested by baude and also verified by me)
--
To view, visit ht
Vinzenz Feenstra has uploaded a new change for review.
Change subject: db: Fix size of guest memory information from INTEGER => BIGINT
..
db: Fix size of guest memory information from INTEGER => BIGINT
When using the maximum sup
Vinzenz Feenstra has posted comments on this change.
Change subject: frontend: Implementation support for GuestOsInfo and Timezone
reporting
..
Patch Set 16: Verified+1
--
To view, visit https://gerrit.ovirt.org/33376
To unsu
Vinzenz Feenstra has posted comments on this change.
Change subject: backend: Implementation support for GuestOsInfo and Timezone
reporting
..
Patch Set 24:
OK the jenkins issue was due to the duplicate DB patch ID 1460 so my
Vinzenz Feenstra has posted comments on this change.
Change subject: backend: Implementation support for GuestOsInfo and Timezone
reporting
..
Patch Set 24: Verified+1
--
To view, visit https://gerrit.ovirt.org/29322
To unsub
Vinzenz Feenstra has posted comments on this change.
Change subject: Mark VM as problematic when timezone or OS changed
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/30508
To unsubscribe, visit https:/
Vinzenz Feenstra has posted comments on this change.
Change subject: backend: Implementation support for GuestOsInfo and Timezone
reporting
..
Patch Set 24:
Rebased and verified, everything seems to work without problems.
Als
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting
..
Patch Set 1: Code-Review-1
Needs addressing of comments by Juan from here:
https://gerrit.o
Vinzenz Feenstra has posted comments on this change.
Change subject: backend: Implementation support for GuestOsInfo and Timezone
reporting
..
Patch Set 23:
Only split off the restapi - The other parts are unchanged.
--
To v
Vinzenz Feenstra has posted comments on this change.
Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting
..
Patch Set 1:
Split of the rest api part, as it seems it was exposed wrong - To not block the
Vinzenz Feenstra has uploaded a new change for review.
Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting
..
restapi: Implementation for GuestOsInfo and Timezone reporting
This patch implements the re
Vinzenz Feenstra has posted comments on this change.
Change subject: Mark VM as problematic when timezone or OS changed
..
Patch Set 8:
(4 comments)
https://gerrit.ovirt.org/#/c/30508/8/frontend/webadmin/modules/webadmin/src/m
Vinzenz Feenstra has posted comments on this change.
Change subject: Mark VM as problematic when timezone or OS changed
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/30508/8/backend/manager/modules/common/src/main/
Vinzenz Feenstra has posted comments on this change.
Change subject: Allow to avoid lock screen on spice disconnect
..
Patch Set 22:
Tested on Host@RHEL7, Engine@Fedora 20
REST API and Frontend reflecting changes accordingly,
Vinzenz Feenstra has posted comments on this change.
Change subject: Allow to avoid lock screen on spice disconnect
..
Patch Set 22: Verified+1
--
To view, visit https://gerrit.ovirt.org/34079
To unsubscribe, visit https://ger
Vinzenz Feenstra has posted comments on this change.
Change subject: Allow to avoid lock screen on spice disconnect
..
Patch Set 22:
(1 comment)
https://gerrit.ovirt.org/#/c/34079/22/packaging/dbscripts/upgrade/03_06_1450_add_
Vinzenz Feenstra has posted comments on this change.
Change subject: app-list: Tracking also cloud-init now
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41246
To unsubscribe, visit https://gerrit.ov
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: app-list: Tracking also cloud-init now
..
app-list: Tracking also cloud-init now
Change-Id: I15a1d4fedaee29c3da2f2e4602e081b53ed2270a
Bug-Url: https:
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: linux: Logout active user support
..
linux: Logout active user support
Change-Id: I1173dc8cb6c2bd68b5e2a2ba4ad69284b2085171
Bug-Url: https://bugzilla
Vinzenz Feenstra has posted comments on this change.
Change subject: linux: Logout active user support
..
Patch Set 4: Code-Review+2 Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/35416/4/scripts/wrappers/ovirt-logout-wra
Vinzenz Feenstra has posted comments on this change.
Change subject: app-list: Tracking also cloud-init now
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41246
To unsubscribe, visit https://gerrit.ovirt
Vinzenz Feenstra has uploaded a new change for review.
Change subject: app-list: Tracking also cloud-init now
..
app-list: Tracking also cloud-init now
Change-Id: I15a1d4fedaee29c3da2f2e4602e081b53ed2270a
Bug-Url: https://bugzil
Vinzenz Feenstra has posted comments on this change.
Change subject: backend: initAppsList should not process null objects
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40381
To unsubscribe, visit https
Vinzenz Feenstra has uploaded a new change for review.
Change subject: backend: initAppsList should not process null objects
..
backend: initAppsList should not process null objects
If the appsList contains non-strings or null v
Vinzenz Feenstra has posted comments on this change.
Change subject: Allow to avoid lock screen on spice disconnect
..
Patch Set 18:
(4 comments)
https://gerrit.ovirt.org/#/c/34079/18//COMMIT_MSG
Commit Message:
Line 3: Autho
Vinzenz Feenstra has posted comments on this change.
Change subject: backend: Implementation support for GuestOsInfo and Timezone
reporting
..
Patch Set 15:
(3 comments)
https://gerrit.ovirt.org/#/c/29322/15/backend/manager/m
Vinzenz Feenstra has posted comments on this change.
Change subject: Allow to avoid lock screen on spice disconnect
..
Patch Set 17:
(1 comment)
> so please remove include it in
> InstanceTypesPopupWidget.createWidgetConfigur
Vinzenz Feenstra has posted comments on this change.
Change subject: core: Fix db upgrage scripts numbering check
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39947
To unsubscribe, visit https://ger
Vinzenz Feenstra has posted comments on this change.
Change subject: core: el7 allows 4TiB max memory, enable for 3.6+ clusters
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/38670
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: Make GuestAgentLinux2 patchable for unit tests
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/28937/4/ovirt-guest-agent/GuestAgentLinux2.py
File o
Vinzenz Feenstra has posted comments on this change.
Change subject: Allow to avoid lock screen on spice disconnect
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/34079/15/backend/manager/modules/restapi/interface/
Vinzenz Feenstra has posted comments on this change.
Change subject: Support for timezone reporting
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/28013/8/ovirt-guest-agent/timezone.py
File ovirt-guest-agent/timezon
Vinzenz Feenstra has posted comments on this change.
Change subject: Add OS info reporting
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/28938
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ge
Vinzenz Feenstra has posted comments on this change.
Change subject: backend: Implementation support for GuestOsInfo and Timezone
reporting
..
Patch Set 14:
(5 comments)
https://gerrit.ovirt.org/#/c/29322/14/backend/manager/m
Vinzenz Feenstra has posted comments on this change.
Change subject: Report guest free/buffered/cached memory
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/35954
To unsubscribe, visit https://gerrit.ovi
Vinzenz Feenstra has posted comments on this change.
Change subject: Report guest free/buffered/cached memory
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/35954
To unsubscribe, visit https://gerrit.ovi
Vinzenz Feenstra has uploaded a new change for review.
Change subject: core: el7 allows 4TiB max memory, enable for 3.6+ clusters
..
core: el7 allows 4TiB max memory, enable for 3.6+ clusters
With this patch we will allow the us
Vinzenz Feenstra has posted comments on this change.
Change subject: Report guest free/buffered/cached memory
..
Patch Set 4:
No worries, I did not forget ;-) I just rebased it to the latest state before I
continue working on
Vinzenz Feenstra has posted comments on this change.
Change subject: Remove unused columns guest_last_log{in,out}_time from database
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/35505
To unsubscribe,
Vinzenz Feenstra has posted comments on this change.
Change subject: Remove unused columns guest_last_log{in,out}_time from database
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/35505
To unsubscribe,
Vinzenz Feenstra has posted comments on this change.
Change subject: packaging: setup: Fix check of pg conf
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37814
To unsubscribe, visit http://gerrit.ovir
Vinzenz Feenstra has posted comments on this change.
Change subject: packaging: setup: Fix check of pg conf
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37814
To unsubscribe, visit http://gerrit.ovirt.o
Vinzenz Feenstra has posted comments on this change.
Change subject: Support for timezone reporting
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/28013
To unsubscribe, visit http://gerrit.ovirt.org/setti
Vinzenz Feenstra has posted comments on this change.
Change subject: Make GuestAgentLinux2 patchable for unit tests
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/28937
To unsubscribe, visit http://gerrit
Vinzenz Feenstra has posted comments on this change.
Change subject: Add OS info reporting
..
Patch Set 5: Verified-1
Missing changes to packaging
--
To view, visit http://gerrit.ovirt.org/28938
To unsubscribe, visit http://g
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: Application list is not returned on 2K3 R2
..
win32: Application list is not returned on 2K3 R2
The application list is not returned, as it se
Vinzenz Feenstra has posted comments on this change.
Change subject: win32: Application list is not returned on 2K3 R2
..
Patch Set 1: Code-Review+2 Verified+1
Same as master
--
To view, visit http://gerrit.ovirt.org/36262
To
Hello Lev Veyde,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/36262
to review the following change.
Change subject: win32: Application list is not returned on 2K3 R2
..
win32: Application list is
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: Application list is not returned on 2K3 R2
..
win32: Application list is not returned on 2K3 R2
The application list is not returned, as it se
Vinzenz Feenstra has posted comments on this change.
Change subject: win32: Application list is not returned on 2K3 R2
..
Patch Set 1: Code-Review+2
Looks good to me, lev please tick verify once you have it verified.
--
To vi
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Report guest free/buffered/cached memory
..
Report guest free/buffered/cached memory
Change-Id: I045a1592e5f83ffc439b5f3aa34ac21d41e9e27e
Bug-Url: https://bu
Vinzenz Feenstra has posted comments on this change.
Change subject: Remove unused columns guest_last_log{in,out}_time from database
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35505/1/packaging/dbscripts/upgrade/0
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Remove unused columns guest_last_log{in,out}_time from database
..
Remove unused columns guest_last_log{in,out}_time from database
Change-Id: I70ade14df12537
Vinzenz Feenstra has uploaded a new change for review.
Change subject: linux: Logout active user support
..
linux: Logout active user support
Change-Id: I1173dc8cb6c2bd68b5e2a2ba4ad69284b2085171
Bug-Url: https://bugzilla.redhat.
Vinzenz Feenstra has posted comments on this change.
Change subject: sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
..
Patch Set 1: Code-Review+2 Verified+1
Same as master
--
To view, visit http://gerrit.ovirt.org/35282
To u
Vinzenz Feenstra has uploaded a new change for review.
Change subject: sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
..
sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
Change-Id: I9247c6c2048a1f20f048c8232d2c18698a414073
Bug-U
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
..
sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
Change-Id: I9247c6c2048a1f20f048c8232d2c18698a4140
Vinzenz Feenstra has posted comments on this change.
Change subject: sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35260
To unsubscribe, visit http://ge
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
..
sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
Change-Id: I9247c6c2048a1f20f048c8232d2c18698a4140
Vinzenz Feenstra has posted comments on this change.
Change subject: sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35260
To unsubscribe, visit http://gerri
Vinzenz Feenstra has uploaded a new change for review.
Change subject: sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
..
sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
Change-Id: I9247c6c2048a1f20f048c8232d2c18698a414073
Bug-U
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: Set registry value with SetValueEx not SetValue
..
win32: Set registry value with SetValueEx not SetValue
_winreg.SetValue only allows to set
Vinzenz Feenstra has uploaded a new change for review.
Change subject: win32: Set registry value with SetValueEx not SetValue
..
win32: Set registry value with SetValueEx not SetValue
_winreg.SetValue only allows to set the defa
Vinzenz Feenstra has posted comments on this change.
Change subject: win32: Set registry value with SetValueEx not SetValue
..
Patch Set 1: Code-Review+2 Verified+1
Same as master
--
To view, visit http://gerrit.ovirt.org/352
Vinzenz Feenstra has uploaded a new change for review.
Change subject: win32: Read serial info directly when not available through WMI
..
win32: Read serial info directly when not available through WMI
The SerialNumber field in
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: Read serial info directly when not available through WMI
..
win32: Read serial info directly when not available through WMI
The SerialNumber f
Vinzenz Feenstra has posted comments on this change.
Change subject: win32: Read serial info directly when not available through WMI
..
Patch Set 1: Code-Review+2 Verified+1
Same as master
--
To view, visit http://gerrit.ovir
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: OpenKey third parameter must always be 0
..
win32: OpenKey third parameter must always be 0
The third parameter is a reserved parameter, where
Vinzenz Feenstra has uploaded a new change for review.
Change subject: win32: OpenKey third parameter must always be 0
..
win32: OpenKey third parameter must always be 0
The third parameter is a reserved parameter, where the fou
Vinzenz Feenstra has posted comments on this change.
Change subject: win32: OpenKey third parameter must always be 0
..
Patch Set 1: Code-Review+2 Verified+1
Same as master
--
To view, visit http://gerrit.ovirt.org/35257
To u
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: Set registry value with SetValueEx not SetValue
..
win32: Set registry value with SetValueEx not SetValue
_winreg.SetValue only allows to set
Vinzenz Feenstra has posted comments on this change.
Change subject: win32: Set registry value with SetValueEx not SetValue
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35163
To unsubscribe, visit ht
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: Read serial info directly when not available through WMI
..
win32: Read serial info directly when not available through WMI
The SerialNumber f
Vinzenz Feenstra has posted comments on this change.
Change subject: win32: Set registry value with SetValueEx not SetValue
..
Patch Set 4: Code-Review+2 Verified+1
Rebased
--
To view, visit http://gerrit.ovirt.org/35163
To u
Vinzenz Feenstra has posted comments on this change.
Change subject: win32: Also the listener thread needs to call CoInitialize
..
Patch Set 4: Code-Review+2 Verified+1
Rebased
--
To view, visit http://gerrit.ovirt.org/34641
Vinzenz Feenstra has posted comments on this change.
Change subject: win32: Read serial info directly when not available through WMI
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35035
To unsubscribe,
1 - 100 of 692 matches
Mail list logo
