Hello Lev Veyde,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/36262

to review the following change.

Change subject: win32: Application list is not returned on 2K3 R2
......................................................................

win32: Application list is not returned on 2K3 R2

The application list is not returned, as it seems that under Windows
2003 R2 the subsequent call to the OpenKey, after the parent key has
been already opened, for some reason looses the correct WOW property,
resulting in key not found error.

Change-Id: I1a801f53fe917e1327b50c75de102d7635959c76
Signed-off-by: Lev Veyde <lve...@redhat.com>
Bug-Url: https://bugzilla.redhat.com/1174853
---
M ovirt-guest-agent/GuestAgentWin32.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-guest-agent 
refs/changes/62/36262/1

diff --git a/ovirt-guest-agent/GuestAgentWin32.py 
b/ovirt-guest-agent/GuestAgentWin32.py
index 395aca1..16da5cd 100644
--- a/ovirt-guest-agent/GuestAgentWin32.py
+++ b/ovirt-guest-agent/GuestAgentWin32.py
@@ -418,7 +418,8 @@
             items = _winreg.QueryInfoKey(rootkey)[0]
             for idx in range(items):
                 cur_key_path = _winreg.EnumKey(rootkey, idx)
-                cur_key = _winreg.OpenKey(rootkey, cur_key_path)
+                cur_key = _winreg.OpenKey(rootkey, cur_key_path, 0,
+                                          view_flag | _winreg.KEY_READ)
                 try:
                     if self._is_item_update(cur_key):
                         continue


-- 
To view, visit http://gerrit.ovirt.org/36262
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a801f53fe917e1327b50c75de102d7635959c76
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to